Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Android API < 23 in StatusBarModule #39669

Closed
wants to merge 8 commits into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Sep 26, 2023

Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class StatusBarModule

chnagelog: [Android][Breaking] Remove support for Android API < 23 in StatusBarModule

Reviewed By: NickGerleman

Differential Revision: D48545516

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Sep 26, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545516

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545516

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 26, 2023
Summary:
Pull Request resolved: facebook#39669

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class StatusBarModule

chnagelog: [Android][Breaking] Remove support for Android API < 23 in StatusBarModule

Reviewed By: NickGerleman

Differential Revision: D48545516

fbshipit-source-id: cecb05c6eb3e9a3e34778cf946c0b7ec161fdaad
@analysis-bot
Copy link

analysis-bot commented Sep 26, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,902,793 +8,566,582
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,381,593 +10,807,184
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 5203354
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545516

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 26, 2023
Summary:
Pull Request resolved: facebook#39669

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class StatusBarModule

chnagelog: [Android][Breaking] Remove support for Android API < 23 in StatusBarModule

Reviewed By: NickGerleman

Differential Revision: D48545516

fbshipit-source-id: 24ef03c1aa318d9b5ca4d496113dafdee95fc60f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545516

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 26, 2023
Summary:
Pull Request resolved: facebook#39669

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class StatusBarModule

chnagelog: [Android][Breaking] Remove support for Android API < 23 in StatusBarModule

Reviewed By: NickGerleman

Differential Revision: D48545516

fbshipit-source-id: d057a89e896ba96f3b2ab5e3ffbd4cbb25cc96f7
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545516

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 26, 2023
Summary:
Pull Request resolved: facebook#39669

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class StatusBarModule

chnagelog: [Android][Breaking] Remove support for Android API < 23 in StatusBarModule

Reviewed By: NickGerleman

Differential Revision: D48545516

fbshipit-source-id: d8f7e75169fcfe15a966d3e08613f2f404d1e7b1
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545516

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 27, 2023
Summary:
Pull Request resolved: facebook#39669

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class StatusBarModule

chnagelog: [Android][Breaking] Remove support for Android API < 23 in StatusBarModule

Reviewed By: NickGerleman

Differential Revision: D48545516

fbshipit-source-id: 1c3de7ab4dadfc80496ef380160133dc6ffd5f42
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545516

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 27, 2023
Summary:
Pull Request resolved: facebook#39669

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class StatusBarModule

chnagelog: [Android][Breaking] Remove support for Android API < 23 in StatusBarModule

Reviewed By: NickGerleman

Differential Revision: D48545516

fbshipit-source-id: feb289b19dcbd9fe6353c8061e93e410f7c96dcb
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545516

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 27, 2023
Summary:
Pull Request resolved: facebook#39669

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class StatusBarModule

changelog: [Android][Breaking] Remove support for Android API < 23 in StatusBarModule

Reviewed By: NickGerleman

Differential Revision: D48545516

fbshipit-source-id: 75f7a219856ed1bf8e8eb749b264fbd92bc45fb3
Summary:
In this diff I'm increasing the minSdk of RN Android to 23 to keep it in sync with Meta min sdk

changelog: [Android][Breaking] Increase min sdk version of RN Android to 23

Differential Revision: D48177965

fbshipit-source-id: 2594a0533dcd3977f91a760d3cdc2daef50c4f48
Summary:
Since minSDK was bumped to Android API 23 we are removing support of code using Android API <23 in

chnagelog: [Android][Breaking] Remove support for Android API < 23 in

Differential Revision: D48545501

fbshipit-source-id: 64b049a95472fb18f5da590a50631fd5372aafcc
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactFragment

chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactFragment

Differential Revision: D48545506

fbshipit-source-id: 2d19e5720e4cfe99e2596fe6789a8139cb517a12
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class DebugOverlayController

chnagelog: [Android][Breaking] Remove support for Android API < 23 in DebugOverlayController

Differential Revision: D48545520

fbshipit-source-id: 06c24220ec8497df4a9c81bf3892a50df6a0f66b
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class WindowOverlayCompat

chnagelog: [Android][Breaking] Remove support for Android API < 23 in WindowOverlayCompat

Differential Revision: D48545505

fbshipit-source-id: 816ee45c3409f7e647f38ca8af2b34edb2c790d0
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class RequestBodyUtil

chnagelog: [Android][Breaking] Remove support for Android API < 23 in RequestBodyUtil

Differential Revision: D48545515

fbshipit-source-id: 919ef84b62023449b3a4869a3e3dcb2c3220d117
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class PermissionsModule

chnagelog: [Android][Breaking] Remove support for Android API < 23 in PermissionsModule

Differential Revision: D48545517

fbshipit-source-id: 63af457379ac07d88ac2f3754873131d29853b74
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48545516

Summary:
Pull Request resolved: facebook#39669

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class StatusBarModule

changelog: [Android][Breaking] Remove support for Android API < 23 in StatusBarModule

Reviewed By: NickGerleman

Differential Revision: D48545516

fbshipit-source-id: 549b5c3870d9723ea1e1825ae523892d9cfaa638
@github-actions
Copy link

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 24c5089

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6eb4f1e.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants