Remove support for Android API < 23 in ReactBaseTextShadowNode #39665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48545509 |
|
This pull request was exported from Phabricator. Differential Revision: D48545509 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
…ook#39665) Summary: Pull Request resolved: facebook#39665 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactBaseTextShadowNode chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactBaseTextShadowNode Reviewed By: NickGerleman Differential Revision: D48545509 fbshipit-source-id: 456005c6d2d7a2e111811ee16f535c8ed3bf774b
mdvacca
force-pushed
the
export-D48545509
branch
from
75d65a5
to
a7a837f
Compare
Base commit: 0b1fcfb |
|
This pull request was exported from Phabricator. Differential Revision: D48545509 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
…ook#39665) Summary: Pull Request resolved: facebook#39665 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactBaseTextShadowNode chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactBaseTextShadowNode Reviewed By: NickGerleman Differential Revision: D48545509 fbshipit-source-id: 8c5c4adacbfe35fdc0b7eab8345ba779389f7a4c
mdvacca
force-pushed
the
export-D48545509
branch
from
a7a837f
to
75b5fac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545509 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
…ook#39665) Summary: Pull Request resolved: facebook#39665 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactBaseTextShadowNode chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactBaseTextShadowNode Reviewed By: NickGerleman Differential Revision: D48545509 fbshipit-source-id: d102b77828f5b2f0d717b09c875e487b040770cc
mdvacca
force-pushed
the
export-D48545509
branch
from
75b5fac
to
ba045cb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545509 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 26, 2023
…ook#39665) Summary: Pull Request resolved: facebook#39665 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactBaseTextShadowNode chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactBaseTextShadowNode Reviewed By: NickGerleman Differential Revision: D48545509 fbshipit-source-id: 30f7d3c5297f9a8f3071150343ec1c50ad449f9f
mdvacca
force-pushed
the
export-D48545509
branch
from
ba045cb
to
551dc2a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545509 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 27, 2023
…ook#39665) Summary: Pull Request resolved: facebook#39665 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactBaseTextShadowNode chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactBaseTextShadowNode Reviewed By: NickGerleman Differential Revision: D48545509 fbshipit-source-id: d813d24333e904db5a37bf592fe96f2ee1c1424c
mdvacca
force-pushed
the
export-D48545509
branch
from
551dc2a
to
12c6f24
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48545509 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 27, 2023
…ook#39665) Summary: Pull Request resolved: facebook#39665 Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactBaseTextShadowNode chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactBaseTextShadowNode Reviewed By: NickGerleman Differential Revision: D48545509 fbshipit-source-id: e125dc454230a42c91711feabe061432cabc8e14
mdvacca
force-pushed
the
export-D48545509
branch
2 times, most recently
from
593da10
to
5b79e39
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 28, 2023
…ook#39665) Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactBaseTextShadowNode changelog: [Android][Breaking] Remove support for Android API < 23 in ReactBaseTextShadowNode Reviewed By: NickGerleman Differential Revision: D48545509
|
This pull request was exported from Phabricator. Differential Revision: D48545509 |
…ook#39665) Summary: Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactBaseTextShadowNode changelog: [Android][Breaking] Remove support for Android API < 23 in ReactBaseTextShadowNode Reviewed By: NickGerleman Differential Revision: D48545509
|
This pull request was exported from Phabricator. Differential Revision: D48545509 |
mdvacca
force-pushed
the
export-D48545509
branch
from
5b79e39
to
0111b3f
Compare
|
This pull request was successfully merged by @mdvacca in 0505f5c. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactBaseTextShadowNode
chnagelog: [Android][Breaking] Remove support for Android API < 23 in ReactBaseTextShadowNode
Reviewed By: NickGerleman
Differential Revision: D48545509