Bump SocketRocket to 0.7.0

[Saadnajmi]

Summary:

We've been using SocketRocket 0.7.0 (to pick up a few bug fixes) without issue in React Native macOS. Might as well bump it upstream before 0.73 if we can.

Changelog:

[IOS] [CHANGED] - Update SocketRocket to 0.7.0

Test Plan:

CI should pass

[efstathiosntonas]

@Saadnajmi there are some issues with 0.7.0 and Flipper on Android: #38012 (comment), don't know if this is fixed or not, just pointing it out

[Saadnajmi]

@Saadnajmi there are some issues with 0.7.0 and Flipper on Android: #38012 (comment), don't know if this is fixed or not, just pointing it out

Thanks! Maybe because Flipper is getting deprecated (see react-native-community/discussions-and-proposals#641) this is fine, but I guess we shall see?

[ryancat]

cc @cipolleschi

I think Flipper is planned to get deprecated, but there are still people using it and we may need to have a deprecation plan for it?

[cipolleschi]

Hi! Unfortunately, the fact that Flipper is deprecated, but not removed, means that we can't bring this in right now. We will have to wait at least until 0.74, when the plan is to remove the default Flipper integration. :(

[Saadnajmi]

Hi! Unfortunately, the fact that Flipper is deprecated, but not removed, means that we can't bring this in right now. We will have to wait at least until 0.74, when the plan is to remove the default Flipper integration. :(

Ok! Since 0.73 branch cut is soon, is it worth it for me to keep this open until right after that, and then have someone look at it / merge so it's in 0.74? Or should I just revisit after 0.73 releases?

[cipolleschi]

I think we can keep this open... just... re-ping us when we removed flipper and we approach 0.74, if we forget about this! 😝

[Saadnajmi]

I think we can keep this open... just... re-ping us when we removed flipper and we approach 0.74, if we forget about this! 😝

Should be good since 899e7cd landed?

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	17,618,997	-7
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,992,556	+4
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 26b4145
Branch: main

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cipolleschi]

I wonder if we have to mark this as breaking, with a message that instruct our users to run bundle exec pod install --repo-update in order to grab the most recent SocketRocket spec... what do you think?

[Saadnajmi]

I wonder if we have to mark this as breaking, with a message that instruct our users to run bundle exec pod install --repo-update in order to grab the most recent SocketRocket spec... what do you think?

I'm pretty used to having to do this whenever any pod changes (folly, etc). Did we have to tell users that when we went to 0.6.1? It doesn't hurt I suppose, but I don't to m think there's a precedent for it. Cocoapods is pretty great at telling you to run exactly that if your pod install fails.

[cipolleschi]

Did we have to tell users that when we went to 0.6.1?

Yes, unfortunately. We had issues where people were asking what to do to fix it, with cocoapods printing the command to run on the screenshot they shared. 🤦

[Saadnajmi]

Did we have to tell users that when we went to 0.6.1?

Yes, unfortunately. We had issues where people were asking what to do to fix it, with cocoapods printing the command to run on the screenshot they shared. 🤦

Ah... yeah I guess so then 🫠. Should I update my change log?

[facebook-github-bot]

@cipolleschi merged this pull request in bab9c83.