Ensure systrace events are always stopped #39561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49413689 |
Summary: Trying to investigate an issue where Systrace events aren't properly ended. For correctness, we should make sure to always end markers that we started. Reviewed By: sammy-SC Differential Revision: D49413689
javache
force-pushed
the
export-D49413689
branch
from
396b5f2
to
25e5952
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49413689 |
|
This pull request was successfully merged by @javache in 97b6829. When will my fix make it into a release? | Upcoming Releases |
ShevO27
pushed a commit
to ShevO27/react-native
that referenced
this pull request
Sep 26, 2023
Summary: Pull Request resolved: facebook#39561 Trying to investigate an issue where Systrace events aren't properly ended. For correctness, we should make sure to always end markers that we started. Reviewed By: sammy-SC Differential Revision: D49413689 fbshipit-source-id: e48e3aef20602e0af9deb924244cdfaf614d11f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Trying to investigate an issue where Systrace events aren't properly ended. For correctness, we should make sure to always end markers that we started.
Differential Revision: D49413689