[iOS] Remove Xcode 12.5 post install workaround #39482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
|
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 8d2af49 |
|
|
@NickGerleman merged this pull request in 0ab8b40. |
blakef
pushed a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
Summary: Now that we updated folly in facebook/react-native@17154a6, we should pick up facebook/folly@4a8837f and probably don't need this post install phase anymore ## Changelog: [IOS] [REMOVED] - Remove Xcode 12.5 post install workaround Pull Request resolved: facebook/react-native#39482 Test Plan: CI should pass Reviewed By: cipolleschi Differential Revision: D49328614 Pulled By: NickGerleman fbshipit-source-id: 05fa0b6d41d07ac552e2b536fbf3a732a31ba713 Original: facebook/react-native@0ab8b40
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Now that we updated folly in facebook/react-native@17154a6, we should pick up facebook/folly@4a8837f and probably don't need this post install phase anymore ## Changelog: [IOS] [REMOVED] - Remove Xcode 12.5 post install workaround Pull Request resolved: facebook/react-native#39482 Test Plan: CI should pass Reviewed By: cipolleschi Differential Revision: D49328614 Pulled By: NickGerleman fbshipit-source-id: 05fa0b6d41d07ac552e2b536fbf3a732a31ba713 Original-Commit: facebook/react-native@0ab8b40
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Now that we updated folly in facebook/react-native@17154a6, we should pick up facebook/folly@4a8837f and probably don't need this post install phase anymore ## Changelog: [IOS] [REMOVED] - Remove Xcode 12.5 post install workaround Pull Request resolved: facebook/react-native#39482 Test Plan: CI should pass Reviewed By: cipolleschi Differential Revision: D49328614 Pulled By: NickGerleman fbshipit-source-id: 05fa0b6d41d07ac552e2b536fbf3a732a31ba713 Original-Commit: facebook/react-native@0ab8b40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Now that we updated folly in 17154a6, we should pick up facebook/folly@4a8837f and probably don't need this post install phase anymore
Changelog:
[IOS] [REMOVED] - Remove Xcode 12.5 post install workaround
Test Plan:
CI should pass