Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix podspecs building with C++ 14 #39464

Closed
wants to merge 1 commit into from
Closed

Fix podspecs building with C++ 14 #39464

wants to merge 1 commit into from

Commits on Sep 15, 2023

  1. Fix podspecs building with C++ 14 (facebook#39464) 

    Summary:

We currently have 854 warnings emitted due to nested namespaces being a C++ 17 extension lol.

This sets the standard explicitly to C++ 20 in the specs emitting the warnings (mostly RCT-Text).

It is undesirable that we add hundreds of warnings to the CocoaPods build without signal. Our Buck build and OSS Android build both treat warnings as errors. But... that is for another day.

Changelog: [Intenrnal]

Reviewed By: cortinico

Differential Revision: D49303081
    @NickGerleman @facebook-github-bot
    NickGerleman authored and facebook-github-bot committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    ec30586 View commit details
    Browse the repository at this point in the history