Introducing LazyTurboModuleManagerDelegate #39462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49172555 |
|
This pull request was exported from Phabricator. Differential Revision: D49172555 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: facebook#39462 In this diff I'm introdcuing the new UnstableAPI called LazyTurboModuleManagerDelegate. The goal of this class is to provide a Lazy registration of TurboModules without relying on ReactModule annotations neither the TurboReactPackage#getReactModuleInfoProvider method. This is not the final implementation, it's just a prototype that will be used to experiment and learn about perf implications. This class will be used in the next diffs of the stack changelog: [intenral] internal Reviewed By: cortinico Differential Revision: D49172555 fbshipit-source-id: d5fa68fd0d8ae96c7f149c5303f9b0f3388da986
mdvacca
force-pushed
the
export-D49172555
branch
from
46baa82
to
46722f6
Compare
Base commit: 598b7ed |
Summary: Fix lint warning changelog: [intenral] internal Differential Revision: D49172556 fbshipit-source-id: 656e067ed908cb78628b4239c2a9dca132fffd51
Summary: In this diff I'm creating an empty constructor on ReactPackageTurboModuleManagerDelegate. This will be used in the next diffs of the stack. I'm also resorting methods for better read of the class changelog: [intenral] internal Differential Revision: D49172554 fbshipit-source-id: 99f31499545fd9cc28cc2a2064d8355670de36e6
|
This pull request was exported from Phabricator. Differential Revision: D49172555 |
Summary: Pull Request resolved: facebook#39462 In this diff I'm introdcuing the new UnstableAPI called LazyTurboModuleManagerDelegate. The goal of this class is to provide a Lazy registration of TurboModules without relying on ReactModule annotations neither the TurboReactPackage#getReactModuleInfoProvider method. This is not the final implementation, it's just a prototype that will be used to experiment and learn about perf implications. This class will be used in the next diffs of the stack changelog: [intenral] internal Reviewed By: cortinico Differential Revision: D49172555 fbshipit-source-id: ef7df6e3ca768fbea8b0c4711b72b0beda2870f5
mdvacca
force-pushed
the
export-D49172555
branch
from
46722f6
to
77eb1be
Compare
|
This pull request has been merged in e513a50. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this diff I'm introdcuing the new UnstableAPI called LazyTurboModuleManagerDelegate.
The goal of this class is to provide a Lazy registration of TurboModules without relying on ReactModule annotations neither the TurboReactPackage#getReactModuleInfoProvider method.
This is not the final implementation, it's just a prototype that will be used to experiment and learn about perf implications.
This class will be used in the next diffs of the stack
changelog: [intenral] internal
Reviewed By: cortinico
Differential Revision: D49172555