Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create empty constructor on ReactPackageTurboModuleManagerDelegate #39461

Closed
wants to merge 2 commits into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Sep 15, 2023

Summary:
In this diff I'm creating an empty constructor on ReactPackageTurboModuleManagerDelegate. This will be used in the next diffs of the stack.
I'm also resorting methods for better read of the class

changelog: [intenral] internal

Reviewed By: arushikesarwani94

Differential Revision: D49172554

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 15, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49172554

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49172554

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 15, 2023
…acebook#39461)

Summary:
Pull Request resolved: facebook#39461

In this diff I'm creating an empty constructor on ReactPackageTurboModuleManagerDelegate. This will be used in the next diffs of the stack.
I'm also resorting methods for better read of the class

changelog: [intenral] internal

Reviewed By: arushikesarwani94

Differential Revision: D49172554

fbshipit-source-id: 1d7c757b686289186954576575b11d5c06d558b4
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49172554

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 15, 2023
…acebook#39461)

Summary:
Pull Request resolved: facebook#39461

In this diff I'm creating an empty constructor on ReactPackageTurboModuleManagerDelegate. This will be used in the next diffs of the stack.
I'm also resorting methods for better read of the class

changelog: [intenral] internal

Reviewed By: arushikesarwani94

Differential Revision: D49172554

fbshipit-source-id: 34e334a0be0e92f4e0711205231b5f872d1f66ab
@analysis-bot
Copy link

analysis-bot commented Sep 15, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,329,245 +0
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,567,993 -17
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 598b7ed
Branch: main

@github-actions
Copy link

github-actions bot commented Sep 15, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against b32de6e

Summary:
Fix lint warning

changelog: [intenral] internal

Differential Revision: D49172556

fbshipit-source-id: adcf972414a64c6d8f5961f8fe2977387d017143
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49172554

…acebook#39461)

Summary:
Pull Request resolved: facebook#39461

In this diff I'm creating an empty constructor on ReactPackageTurboModuleManagerDelegate. This will be used in the next diffs of the stack.
I'm also resorting methods for better read of the class

changelog: [intenral] internal

Reviewed By: arushikesarwani94

Differential Revision: D49172554

fbshipit-source-id: 6a61e75837e7ed9ae0f0f9a680d62286ee72f76e
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 040d139.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants