deprecate mHasConstants in ReactModuleInfo #39458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49262577 |
|
This pull request was exported from Phabricator. Differential Revision: D49262577 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39458 ## Changelog [Android][Deprecated] - hasConstants in ReactModuleInfo is marked as deprecated getting rid of `mHasConstants` ivar here and marking the getter as deprecated Reviewed By: cortinico Differential Revision: D49262577 fbshipit-source-id: 30965b1a84be8671c6d4bf3a45aff65128c00512
philIip
force-pushed
the
export-D49262577
branch
from
546718c
to
d4972df
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49262577 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39458 ## Changelog [Android][Deprecated] - hasConstants in ReactModuleInfo is marked as deprecated getting rid of `mHasConstants` ivar here and marking the getter as deprecated Reviewed By: cortinico Differential Revision: D49262577 fbshipit-source-id: afec81c845c4f6b2380c9337d8c1f9f3a42546cd
philIip
force-pushed
the
export-D49262577
branch
from
d4972df
to
bfb16c6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49262577 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39458 ## Changelog [Android][Deprecated] - hasConstants in ReactModuleInfo is marked as deprecated getting rid of `mHasConstants` ivar here and marking the getter as deprecated Reviewed By: cortinico Differential Revision: D49262577 fbshipit-source-id: 347e0590643d51e2f86c3617de841d4f428facc8
philIip
force-pushed
the
export-D49262577
branch
from
bfb16c6
to
2137aa2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49262577 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39458 ## Changelog [Android][Deprecated] - hasConstants in ReactModuleInfo is marked as deprecated getting rid of `mHasConstants` ivar here and marking the getter as deprecated Reviewed By: cortinico Differential Revision: D49262577 fbshipit-source-id: 48a1b880443d670848e5252194a4fe85a736ba35
philIip
force-pushed
the
export-D49262577
branch
from
2137aa2
to
a071e3a
Compare
Differential Revision: D49210251 fbshipit-source-id: 9e528d4a6998151a64ee6cd4c2403aa471fad73a
Summary: Pull Request resolved: facebook#39458 ## Changelog [Android][Deprecated] - hasConstants in ReactModuleInfo is marked as deprecated getting rid of `mHasConstants` ivar here and marking the getter as deprecated Reviewed By: cortinico Differential Revision: D49262577 fbshipit-source-id: 82e3bc3c6618b35fa7652ae32174b3dc445747bc
|
This pull request was exported from Phabricator. Differential Revision: D49262577 |
philIip
force-pushed
the
export-D49262577
branch
from
a071e3a
to
2b69ddf
Compare
Base commit: 88e19c0 |
|
This pull request has been merged in 196d9f9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog
[Android][Deprecated] - hasConstants in ReactModuleInfo is marked as deprecated
getting rid of
mHasConstantsivar here and marking the getter as deprecatedReviewed By: cortinico
Differential Revision: D49262577