C++ 20 all the things #39454
Closed
C++ 20 all the things #39454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
NickGerleman
force-pushed
the
export-D49271685
branch
from
3410839
to
7405317
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39454 Textual replacement of C++ 17 with C++ 20, to see if we can start building with it everywhere. Changelog: [Internal] Differential Revision: D49271685 fbshipit-source-id: 48798e550adb4334df2732e100ffb2fc1afdeb5c
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39454 Build with C++ 20 everywhere. Updates folly by three months to avoid a warning (we are still way behind). Replaces a deprecated atomic usage with equivalent. Changelog: [Internal] Differential Revision: D49271685 fbshipit-source-id: 57e5d7e1dae802ce61e942e8c2975d59b0f03d49
NickGerleman
force-pushed
the
export-D49271685
branch
from
7405317
to
feb6424
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39454 Build with C++ 20 everywhere. Updates folly by three months to avoid a warning (we are still way behind). Replaces a deprecated atomic usage with equivalent. Changelog: [Internal] Differential Revision: D49271685 fbshipit-source-id: c5c176a612b788e9611df024182347de468d697f
NickGerleman
force-pushed
the
export-D49271685
branch
from
feb6424
to
63fd890
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39454 1. Build with C++ 20 everywhere. 2. Update folly by three months to avoid a warning (we are still multiple years behind). 3. Adds some headers now included to the folly podspec 4. Replaces a deprecated atomic usage with equivalent. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D49271685 fbshipit-source-id: 98e754bb5f9fa063c553e3a018e6dbd69de1063b
NickGerleman
force-pushed
the
export-D49271685
branch
from
63fd890
to
8cf939f
Compare
Base commit: 3b27c39 |
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39454 1. Build with C++ 20 everywhere. 2. Update folly by three months to avoid a warning (we are still multiple years behind). 3. Adds some headers now included to the folly podspec 4. Replaces a deprecated atomic usage with equivalent. 5. Fixes deprecated implicit capturing `this` by value in lambdas Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D49271685 fbshipit-source-id: bc0707df5451cad3ca495e716a245a648f6dba47
NickGerleman
force-pushed
the
export-D49271685
branch
from
8cf939f
to
7b6bb75
Compare
NickGerleman
commented
Sep 14, 2023
NickGerleman
commented
Sep 14, 2023
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39454 1. Build with C++ 20 everywhere. 2. Update folly by three months to avoid a warning (we are still multiple years behind). 3. Adds some headers now included to the folly podspec 4. Replaces a deprecated atomic usage with equivalent. 5. Fixes deprecated implicit capturing `this` by value in lambdas Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D49271685 fbshipit-source-id: f3fcecd79409a01c63e3c96e7e582cd87292432f
NickGerleman
force-pushed
the
export-D49271685
branch
from
5bb0900
to
4ec8568
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39454 1. Build with C++ 20 everywhere. 2. Update folly by three months to avoid a warning (we are still multiple years behind). 3. Adds some headers now included to the folly podspec 4. Replaces a deprecated atomic usage with equivalent. 5. Fixes deprecated implicit capturing `this` by value in lambdas Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D49271685 fbshipit-source-id: 9e5d74f4dd404591be8383460a92447231130235
NickGerleman
force-pushed
the
export-D49271685
branch
from
4ec8568
to
ab4c02c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: 1. Build with C++ 20 everywhere. 2. Update folly to avoid a warning, and let us opt out of heavy bits required for supporting coroutines (we are still more than a year behind). 3. Adds some headers now included to the folly podspec 4. Replaces a deprecated atomic usage with equivalent. 5. Fixes deprecated implicit capturing `this` by value in lambdas Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D49271685
NickGerleman
force-pushed
the
export-D49271685
branch
from
d1a8790
to
78e12d3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: 1. Build with C++ 20 everywhere. 2. Update folly to avoid a warning, and let us opt out of heavy bits required for supporting coroutines (we are still more than a year behind). 3. Update the folly podspec for the new version of folly 4. Update the many, many, copy/pasted header search paths for folly dependencies to be able to resolve fmt, now exposed to folly headers 4. Replaces a deprecated atomic usage with equivalent. 5. Fixes a deprecated implicit capturing `this` by value in lambda (same behavior, added a TODO because it seems sus) Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D49271685
NickGerleman
force-pushed
the
export-D49271685
branch
from
78e12d3
to
18e8d93
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: 1. Build with C++ 20 everywhere. 2. Update folly to avoid a warning, and let us opt out of heavy bits required for supporting coroutines (we are still more than a year behind). 3. Update the folly podspec for the new version of folly 4. Update the many, many, copy/pasted header search paths for folly dependencies to be able to resolve fmt, now exposed to folly headers 4. Replaces a deprecated atomic usage with equivalent. 5. Fixes a deprecated implicit capturing `this` by value in lambda (same behavior, added a TODO because it seems sus) Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D49271685
NickGerleman
force-pushed
the
export-D49271685
branch
from
18e8d93
to
51c23bd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: 1. Build with C++ 20 everywhere. 2. Update folly in OSS build to avoid a warning, and let us opt out of heavy bits required for supporting coroutines (we are still more than a year behind). 3. Update the folly podspec for the new version of folly 4. Update the many, many, copy/pasted header search paths for folly dependencies to be able to resolve fmt, now exposed to folly headers 4. Replaces a deprecated atomic usage with equivalent. 5. Fixes a deprecated implicit capturing `this` by value in lambda (same behavior, added a TODO because it seems sus) Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D49271685
NickGerleman
force-pushed
the
export-D49271685
branch
from
51c23bd
to
fea1e8b
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: 1. Build with C++ 20 everywhere. 2. Update folly in OSS build to avoid a warning, and let us opt out of heavy bits required for supporting coroutines (we are still more than a year behind). 3. Update the folly podspec for the new version of folly 4. Update the many, many, copy/pasted header search paths for folly dependencies to be able to resolve fmt, now exposed to folly headers 4. Replaces a deprecated atomic usage with equivalent. 5. Fixes a deprecated implicit capturing `this` by value in lambda (same behavior, added a TODO because it seems sus) Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D49271685
NickGerleman
force-pushed
the
export-D49271685
branch
from
fea1e8b
to
77a6bfc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: 1. Build with C++ 20 everywhere. 2. Update folly in OSS build to avoid a warning, and let us opt out of heavy bits required for supporting coroutines (we are still more than a year behind). 3. Update the folly podspec for the new version of folly 4. Update the many, many, copy/pasted header search paths for folly dependencies to be able to resolve fmt, now exposed to folly headers 4. Replaces a deprecated atomic usage with equivalent. 5. Fixes a deprecated implicit capturing `this` by value in lambda (same behavior, added a TODO because it seems sus) Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D49271685
NickGerleman
force-pushed
the
export-D49271685
branch
from
77a6bfc
to
ac3b303
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
Summary: 1. Build with C++ 20 everywhere. 2. Update folly in OSS build to avoid a warning, and let us opt out of heavy bits required for supporting coroutines (we are still more than a year behind). 3. Update the folly podspec for the new version of folly 4. Update the many, many, copy/pasted header search paths for folly dependencies to be able to resolve fmt, now exposed to folly headers 4. Replaces a deprecated atomic usage with equivalent. 5. Fixes a deprecated implicit capturing `this` by value in lambda (same behavior, added a TODO because it seems sus) Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D49271685
NickGerleman
force-pushed
the
export-D49271685
branch
from
ac3b303
to
92fbf72
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49271685 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: facebook#39454 1. Build with C++ 20 everywhere. 2. Update folly by three months to avoid a warning (we are still multiple years behind). 3. Adds some headers now included to the folly podspec 4. Replaces a deprecated atomic usage with equivalent. 5. Fixes deprecated implicit capturing `this` by value in lambdas Changelog: [Internal] Differential Revision: https://www.internalfb.com/diff/D49271685?entry_point=27 fbshipit-source-id: ea627dcc0d6ed94faac8b152ff82e000b11b53b2
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: facebook#39454 1. Build with C++ 20 everywhere. 2. Update folly by three months to avoid a warning (we are still multiple years behind). 3. Adds some headers now included to the folly podspec 4. Replaces a deprecated atomic usage with equivalent. 5. Fixes deprecated implicit capturing `this` by value in lambdas Changelog: [Internal] Differential Revision: https://www.internalfb.com/diff/D49271685?entry_point=27 fbshipit-source-id: 14b8a0e96ef5b2e493380fe45a12eda8a581f2d5
|
This pull request was successfully merged by @NickGerleman in 17154a6. When will my fix make it into a release? | Upcoming Releases |
blakef
pushed a commit
to blakef/template
that referenced
this pull request
Feb 28, 2024
Summary: Pull Request resolved: facebook/react-native#39454 1. Build with C++ 20 everywhere. 2. Update folly in OSS build to avoid a warning, and let us opt out of heavy bits required for supporting coroutines (we are still more than a year behind). 3. Update the folly podspec for the new version of folly 4. Update the many, many, copy/pasted header search paths for folly dependencies to be able to resolve fmt, now exposed to folly headers 4. Replaces a deprecated atomic usage with equivalent. 5. Fixes a deprecated implicit capturing `this` by value in lambda (same behavior, added a TODO because it seems sus) Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D49271685 fbshipit-source-id: 16610f7bcd1032d5796cc11f1cfa92a33d8c2593 Original: facebook/react-native@17154a6
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#39454 1. Build with C++ 20 everywhere. 2. Update folly in OSS build to avoid a warning, and let us opt out of heavy bits required for supporting coroutines (we are still more than a year behind). 3. Update the folly podspec for the new version of folly 4. Update the many, many, copy/pasted header search paths for folly dependencies to be able to resolve fmt, now exposed to folly headers 4. Replaces a deprecated atomic usage with equivalent. 5. Fixes a deprecated implicit capturing `this` by value in lambda (same behavior, added a TODO because it seems sus) Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D49271685 fbshipit-source-id: 16610f7bcd1032d5796cc11f1cfa92a33d8c2593 Original-Commit: facebook/react-native@17154a6
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Feb 29, 2024
Summary: Pull Request resolved: facebook/react-native#39454 1. Build with C++ 20 everywhere. 2. Update folly in OSS build to avoid a warning, and let us opt out of heavy bits required for supporting coroutines (we are still more than a year behind). 3. Update the folly podspec for the new version of folly 4. Update the many, many, copy/pasted header search paths for folly dependencies to be able to resolve fmt, now exposed to folly headers 4. Replaces a deprecated atomic usage with equivalent. 5. Fixes a deprecated implicit capturing `this` by value in lambda (same behavior, added a TODO because it seems sus) Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D49271685 fbshipit-source-id: 16610f7bcd1032d5796cc11f1cfa92a33d8c2593 Original-Commit: facebook/react-native@17154a6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Textual replacement of C++ 17 with C++ 20, to see if we can start building with it everywhere.
Changelog: [Internal]
Differential Revision: D49271685