C++ style enums 4/N: Errata #39451
Closed
C++ style enums 4/N: Errata #39451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49270354 |
|
This pull request was exported from Phabricator. Differential Revision: D49270354 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39451 X-link: facebook/yoga#1388 This converts usages of YGErrata to Errata Differential Revision: D49270354 fbshipit-source-id: 94c4474933e2b67838abf829029bb1eea4a893f7
NickGerleman
force-pushed
the
export-D49270354
branch
from
1f9aa87
to
5ad7b63
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/react-native#39451 Pull Request resolved: facebook#1388 This converts usages of YGErrata to Errata Differential Revision: D49270354 fbshipit-source-id: 994e2266e19c22c9db30a80733d1ab696d03ead8
Base commit: 598b7ed |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39451 Pull Request resolved: facebook#1388 This converts usages of YGErrata to Errata Reviewed By: rozele Differential Revision: D49270354 fbshipit-source-id: d1ba4c38ca0dfd2c2d04b11e76a4313f7fcfd54c
|
This pull request was exported from Phabricator. Differential Revision: D49270354 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: facebook#39451 X-link: facebook/yoga#1388 This converts usages of YGErrata to Errata Reviewed By: rozele Differential Revision: D49270354 fbshipit-source-id: d73c73396574f982fe0cbc2e61f812ec4846d629
NickGerleman
force-pushed
the
export-D49270354
branch
from
5ad7b63
to
f6fa933
Compare
Summary: This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Differential Revision: D49267996 fbshipit-source-id: 94450c9d9e36e73252235138a53a78b8a1e0dddf
Differential Revision: D49269117 fbshipit-source-id: 6802a41c4b24e6056f7d5fcdc1701c513da2e36a
Differential Revision: D49269440 fbshipit-source-id: 022ba5c19bc0ccb8b81577428e865dfc5c4bf821
Summary: Pull Request resolved: facebook#39451 X-link: facebook/yoga#1388 This converts usages of YGErrata to Errata Reviewed By: rozele Differential Revision: D49270354 fbshipit-source-id: 82b09244f683ebc1a06b672b6d887a38c2d8f94b
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39451 Pull Request resolved: facebook#1388 This converts usages of YGErrata to Errata Reviewed By: rozele Differential Revision: D49270354 fbshipit-source-id: 24c18378cda3a90f5ff6c90c118d4e940eb261ef
|
This pull request was exported from Phabricator. Differential Revision: D49270354 |
NickGerleman
force-pushed
the
export-D49270354
branch
from
f6fa933
to
8320d16
Compare
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39451 Pull Request resolved: #1388 This converts usages of YGErrata to Errata Reviewed By: rozele Differential Revision: D49270354 fbshipit-source-id: 39c0d26a1609cca0a96da843796ab41c81e3af93
|
This pull request has been merged in c64c26c. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39451 X-link: facebook/yoga#1388 This converts usages of YGErrata to Errata Reviewed By: rozele Differential Revision: D49270354 fbshipit-source-id: 39c0d26a1609cca0a96da843796ab41c81e3af93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This converts usages of YGErrata to Errata
Differential Revision: D49270354