C++ style enums 5/N: LogLevel #39447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49270695 |
|
This pull request was exported from Phabricator. Differential Revision: D49270695 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/yoga#1387 Pull Request resolved: facebook#39447 This converts usages of YGLogLevel to LogLevel Differential Revision: D49270695 fbshipit-source-id: 1680a5297028ee620b3be7e9aefbd95fd4943ced
NickGerleman
force-pushed
the
export-D49270695
branch
from
dd92855
to
d1aabc9
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#1387 X-link: facebook/react-native#39447 This converts usages of YGLogLevel to LogLevel Differential Revision: D49270695 fbshipit-source-id: 67de6341cbec8e0109ba149a6ca9d32bb513790f
Base commit: 598b7ed |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: facebook#1387 X-link: facebook/react-native#39447 This converts usages of YGLogLevel to LogLevel Reviewed By: rozele Differential Revision: D49270695 fbshipit-source-id: 91e02e92fc93c6c03a1f01914d281499335e2e69
|
This pull request was exported from Phabricator. Differential Revision: D49270695 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/yoga#1387 Pull Request resolved: facebook#39447 This converts usages of YGLogLevel to LogLevel Reviewed By: rozele Differential Revision: D49270695 fbshipit-source-id: 4089e71280864cd1d27f064aa83a3e7ee42139de
NickGerleman
force-pushed
the
export-D49270695
branch
from
d1aabc9
to
7be3175
Compare
Summary: This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Differential Revision: D49267996 fbshipit-source-id: a136d6813d393f9874ec88b958071c13b42f865c
Differential Revision: D49269117 fbshipit-source-id: 1ffafa9405cdf3818562f4605f28f14e18c05c0f
Differential Revision: D49269440 fbshipit-source-id: 58d262cc6a2bf46dd4aad8254aeea788c208f2ce
Summary: This converts usages of YGErrata to Errata Differential Revision: D49270354 fbshipit-source-id: db855c732477bcb7a00474cbe090d30e137d88e5
Summary: X-link: facebook/yoga#1387 Pull Request resolved: facebook#39447 This converts usages of YGLogLevel to LogLevel Reviewed By: rozele Differential Revision: D49270695 fbshipit-source-id: 20603e1a05b8200fed98e22e2bf8a34674a4d484
|
This pull request was exported from Phabricator. Differential Revision: D49270695 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: facebook#1387 X-link: facebook/react-native#39447 This converts usages of YGLogLevel to LogLevel Reviewed By: rozele Differential Revision: D49270695 fbshipit-source-id: 70509b65d5e503010fe4490db88a3dd9835c5370
NickGerleman
force-pushed
the
export-D49270695
branch
from
7be3175
to
4b21a5f
Compare
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: #1387 X-link: facebook/react-native#39447 This converts usages of YGLogLevel to LogLevel Reviewed By: rozele Differential Revision: D49270695 fbshipit-source-id: 2ba5b4f2b0af93fef89dbbb2ce54c2f486670aac
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/yoga#1387 X-link: facebook/react-native#39447 This converts usages of YGLogLevel to LogLevel Reviewed By: rozele Differential Revision: D49270695 fbshipit-source-id: 2ba5b4f2b0af93fef89dbbb2ce54c2f486670aac
|
This pull request has been merged in 2681b0e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This converts usages of YGLogLevel to LogLevel
Differential Revision: D49270695