C++ style enums 1/N: Generator #39446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49267996 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/react-native#39446 This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Differential Revision: D49267996
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/yoga#1384 This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Differential Revision: D49267996
NickGerleman
force-pushed
the
export-D49267996
branch
from
d1bdbec
to
2aeabae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49267996 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 14, 2023
Summary: X-link: facebook/react-native#39446 This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Differential Revision: D49267996
Base commit: 598b7ed |
Summary: X-link: facebook/yoga#1384 This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Reviewed By: rozele Differential Revision: D49267996
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/react-native#39446 This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Reviewed By: rozele Differential Revision: D49267996
NickGerleman
force-pushed
the
export-D49267996
branch
from
2aeabae
to
215cad3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49267996 |
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: #1384 X-link: facebook/react-native#39446 This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Reviewed By: rozele Differential Revision: D49267996 fbshipit-source-id: 1c41164c377b317c1fef97811c46cbc00b5a837e
|
This pull request has been merged in 14bbbdc. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 15, 2023
Summary: X-link: facebook/yoga#1384 X-link: facebook/react-native#39446 This adds logic to the enum generator to generate C++ style scoped enums. This gives us a few nicities over C enums, even if both must exist: 1. We can add types and keep unsgined enums directly in bitfields 2. Style/readability 3. Avoiding implicit int conversion Reviewed By: rozele Differential Revision: D49267996 fbshipit-source-id: 1c41164c377b317c1fef97811c46cbc00b5a837e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds logic to the enum generator to generate C++ style scoped enums.
This gives us a few nicities over C enums, even if both must exist:
Differential Revision: D49267996