Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter yoga props 2/x - filter out yoga props at creation of YogaStylableProps #39431

Closed
wants to merge 2 commits into from

Conversation

zeyap
Copy link
Contributor

@zeyap zeyap commented Sep 13, 2023

Summary:
Changelog: [Android][Breaking] - Do not enable excludeYogaFromRawProps feature flag, if you need to pass layout props to Java view managers when using new architecture
[Internal]

Differential Revision: D49114771

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 13, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49114771

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49114771

zeyap added a commit to zeyap/react-native that referenced this pull request Sep 13, 2023
…ableProps (facebook#39431)

Summary:
Pull Request resolved: facebook#39431

Changelog: [Android][Breaking] - Do not enable `excludeYogaFromRawProps` feature flag, if you need to pass layout props to Java view managers when using new architecture
[Internal]

Differential Revision: D49114771

fbshipit-source-id: 8bec358040c9473c03615ccf8fb0fd07a1fab475
@analysis-bot
Copy link

analysis-bot commented Sep 13, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,328,905 +5,056
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,568,281 +5,548
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 4b6fd81
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49114771

zeyap added a commit to zeyap/react-native that referenced this pull request Sep 14, 2023
…ableProps (facebook#39431)

Summary:
Pull Request resolved: facebook#39431

Changelog: [Android][Breaking] - Do not enable `excludeYogaFromRawProps` feature flag, if you need to pass layout props to Java view managers when using new architecture
[Internal]

Reviewed By: NickGerleman

Differential Revision: D49114771

fbshipit-source-id: bfda71f8453daecd3a53de682974a794b0d49c5a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49114771

zeyap added a commit to zeyap/react-native that referenced this pull request Sep 14, 2023
…ableProps (facebook#39431)

Summary:
Pull Request resolved: facebook#39431

Changelog: [Android][Breaking] - Do not enable `excludeYogaFromRawProps` feature flag, if you need to pass layout props to Java view managers when using new architecture
[Internal]

Reviewed By: NickGerleman

Differential Revision: D49114771

fbshipit-source-id: 8bc172ccc4d1804410cffb8c481a40d6cbd85502
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49114771

zeyap added a commit to zeyap/react-native that referenced this pull request Sep 14, 2023
…ableProps (facebook#39431)

Summary:
Pull Request resolved: facebook#39431

Changelog: [Android][Breaking] - Do not enable `excludeYogaFromRawProps` feature flag, if you need to pass layout props to Java view managers when using new architecture
[Internal]

Reviewed By: NickGerleman

Differential Revision: D49114771

fbshipit-source-id: fedcf966e799e54a4d4e0b4721fec5df88d967bd
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49114771

zeyap added a commit to zeyap/react-native that referenced this pull request Sep 14, 2023
…ableProps (facebook#39431)

Summary:
Pull Request resolved: facebook#39431

Changelog: [Android][Breaking] - Do not enable `excludeYogaFromRawProps` feature flag, if you need to pass layout props to Java view managers when using new architecture
[Internal]

Reviewed By: NickGerleman

Differential Revision: D49114771

fbshipit-source-id: ac74dd28d2dbe908172464c5ff29932112ba1667
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49114771

zeyap added a commit to zeyap/react-native that referenced this pull request Sep 14, 2023
…ableProps (facebook#39431)

Summary:
Pull Request resolved: facebook#39431

Changelog: [Android][Breaking] - Do not enable `excludeYogaFromRawProps` feature flag, if you need to pass layout props to Java view managers when using new architecture
[Internal]

Reviewed By: NickGerleman

Differential Revision: D49114771

fbshipit-source-id: 1309fa1c3b4e041395a1c6d8d2401160c5089b5d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49114771

zeyap added a commit to zeyap/react-native that referenced this pull request Sep 14, 2023
…ableProps (facebook#39431)

Summary:
Pull Request resolved: facebook#39431

Changelog: [Android][Breaking] - Do not enable `excludeYogaFromRawProps` feature flag, if you need to pass layout props to Java view managers when using new architecture
[Internal]

Reviewed By: NickGerleman

Differential Revision: D49114771

fbshipit-source-id: 06949b167decd3f1c7db8ac65bab6ff250fb9e95
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49114771

zeyap added a commit to zeyap/react-native that referenced this pull request Sep 14, 2023
…ableProps (facebook#39431)

Summary:
Pull Request resolved: facebook#39431

Changelog: [Android][Breaking] - Do not enable `excludeYogaFromRawProps` feature flag, if you need to pass layout props to Java view managers when using new architecture
[Internal]

Reviewed By: NickGerleman

Differential Revision: D49114771

fbshipit-source-id: 1e2b23d19d12da8a37db33edd75d744e2fd7673e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49114771

zeyap added a commit to zeyap/react-native that referenced this pull request Sep 14, 2023
…ableProps (facebook#39431)

Summary:
Pull Request resolved: facebook#39431

Changelog: [Android][Breaking] - Do not enable `excludeYogaFromRawProps` feature flag, if you need to pass layout props to Java view managers when using new architecture
[Internal]

Reviewed By: NickGerleman

Differential Revision: D49114771

fbshipit-source-id: e4fb7cc5512a2baf97767084b5b907b07bb17c65
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49114771

zeyap added a commit to zeyap/react-native that referenced this pull request Sep 14, 2023
…ableProps (facebook#39431)

Summary:
Pull Request resolved: facebook#39431

Changelog: [Android][Breaking] - Do not enable `excludeYogaFromRawProps` feature flag, if you need to pass layout props to Java view managers when using new architecture
[Internal]

Reviewed By: NickGerleman

Differential Revision: D49114771

fbshipit-source-id: f4006e2870aa28f6cf70644621b8841c50a5c63e
Zeya Peng and others added 2 commits September 14, 2023 12:11
Differential Revision: D49162188

fbshipit-source-id: 7c8a6bfe010389cd64064d51e460fcab378c9785
…ableProps (facebook#39431)

Summary:
Pull Request resolved: facebook#39431

Changelog: [Android][Breaking] - Do not enable `excludeYogaFromRawProps` feature flag, if you need to pass layout props to Java view managers when using new architecture
[Internal]

Reviewed By: NickGerleman

Differential Revision: D49114771

fbshipit-source-id: ee5497a0a767275836b5f70962e2412d2f27d865
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49114771

@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against aa6d49d

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 14, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 88e19c0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants