Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce visibility of TurboModuleInteropUtils #39352

Closed
wants to merge 8 commits into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Sep 8, 2023

Summary:
Reduce visibility of TurboModuleInteropUtils to package only

changelog: [intenral] internal

Reviewed By: cortinico

Differential Revision: D49077066

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Sep 8, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077066

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077066

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39352

Reduce visibility of TurboModuleInteropUtils to package only

changelog: [intenral] internal

Reviewed By: cortinico

Differential Revision: D49077066

fbshipit-source-id: 67a0dcbfc173a9aa35a7233d4650477357c6091b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077066

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39352

Reduce visibility of TurboModuleInteropUtils to package only

changelog: [intenral] internal

Reviewed By: cortinico

Differential Revision: D49077066

fbshipit-source-id: 2674754f1eb629622c44aca61b88fafc607a84e0
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077066

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39352

Reduce visibility of TurboModuleInteropUtils to package only

changelog: [intenral] internal

Reviewed By: cortinico

Differential Revision: D49077066

fbshipit-source-id: f66ad19322ee39c14ef73d0ab5163be3c0aa7b67
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077066

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39352

Reduce visibility of TurboModuleInteropUtils to package only

changelog: [intenral] internal

Reviewed By: cortinico

Differential Revision: D49077066

fbshipit-source-id: fd98c65a8447388bcf2e06a8338546ad11b885da
@analysis-bot
Copy link

analysis-bot commented Sep 8, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,969,900 +6
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,563,141 -17
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 9faf256
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077066

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 11, 2023
Summary:
Pull Request resolved: facebook#39352

Reduce visibility of TurboModuleInteropUtils to package only

changelog: [intenral] internal

Reviewed By: cortinico

Differential Revision: D49077066

fbshipit-source-id: 343460d4f2c1aae037e3bc3c7279f23dec47da9f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077066

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 13, 2023
Summary:
Pull Request resolved: facebook#39352

Reduce visibility of TurboModuleInteropUtils to package only

changelog: [intenral] internal

Reviewed By: cortinico

Differential Revision: D49077066

fbshipit-source-id: ba719ebd2badc555a4242b9299f75b8c35ad1ccc
@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 6804994

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077066

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 13, 2023
Summary:
Pull Request resolved: facebook#39352

Reduce visibility of TurboModuleInteropUtils to package only

changelog: [intenral] internal

Reviewed By: cortinico

Differential Revision: D49077066

fbshipit-source-id: b463ff6494a2aebfa3cc8ae67deb31f6020a6d1e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077066

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 14, 2023
Summary:
Pull Request resolved: facebook#39352

Reduce visibility of TurboModuleInteropUtils to package only

changelog: [intenral] internal

Reviewed By: cortinico

Differential Revision: D49077066

fbshipit-source-id: d10f4dce4ca82e8e5807fb4f3aca4a5bc91be831
Differential Revision: D48992474

fbshipit-source-id: 686b68e5cbdb56e01246515fe7a474756eb379c7
Differential Revision: D48992720

fbshipit-source-id: cd182076abc9c30e238369348ac0ffac140c7319
Summary:
In this diff I'm introducing the new DeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in
OSS.

changelog: [Android] Introduce DeprecatedInNewArchitecture annotation

Differential Revision: D49068234

fbshipit-source-id: 10ace030ab944999bdc42d35463598c9fc99b79c
…le instead

Differential Revision: D48992719

fbshipit-source-id: 8006566589b7524b79f4308651a69b1bbe1ce0e0
Summary:
Mark ReactPackage.getModule as UnstableReactNativeAPI

changelog: [internal] internal

Differential Revision: D49068233

fbshipit-source-id: e4f11c983f9e331d1e6648353195e80c65f0c4be
Summary:
Fix lint warning in MainReactPackage, as reactModule could be null

changelog: [internal] internal

Differential Revision: D49077064

fbshipit-source-id: 399d730c4b34aa75e8fb45f84a06ec02b47b57ec
Summary:
Annotate HybridData with DoNotStrip

changelog: [intenral] internal

Differential Revision: D49077065

fbshipit-source-id: c6965587f0a5c81b80a75169a8be38920a2989c3
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077066

Summary:
Pull Request resolved: facebook#39352

Reduce visibility of TurboModuleInteropUtils to package only

changelog: [intenral] internal

Reviewed By: cortinico

Differential Revision: D49077066

fbshipit-source-id: 5f6aa8bd171b2306cb4373cf77bdb0499397acdf
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 46a524f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants