Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce WillBeDeprecatedInNewArchitecture annotation #39351

Closed
wants to merge 3 commits into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Sep 8, 2023

Summary:
In this diff I'm introducing the new WillBeDeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in
OSS.

changelog: [Android] Introduce WillBeDeprecatedInNewArchitecture annotation

Reviewed By: cortinico

Differential Revision: D49068234

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 8, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068234

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068234

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39351

In this diff I'm introducing the new WillBeDeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in
OSS.

changelog: [Android] Introduce WillBeDeprecatedInNewArchitecture annotation

Reviewed By: cortinico

Differential Revision: D49068234

fbshipit-source-id: 54e37885ee69d5a9be29675c1b69218edda4933f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068234

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39351

In this diff I'm introducing the new WillBeDeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in
OSS.

changelog: [Android] Introduce WillBeDeprecatedInNewArchitecture annotation

Reviewed By: cortinico

Differential Revision: D49068234

fbshipit-source-id: 2d94148f300066b325c085059723da0527320d4f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068234

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39351

In this diff I'm introducing the new WillBeDeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in
OSS.

changelog: [Android] Introduce WillBeDeprecatedInNewArchitecture annotation

Reviewed By: cortinico

Differential Revision: D49068234

fbshipit-source-id: 42aae348df40c6a49c96a4bb1a9b3d29999b5c0c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068234

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 11, 2023
Summary:
Pull Request resolved: facebook#39351

In this diff I'm introducing the new WillBeDeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in
OSS.

changelog: [Android] Introduce WillBeDeprecatedInNewArchitecture annotation

Reviewed By: cortinico

Differential Revision: D49068234

fbshipit-source-id: f2e3af5221ef132d5be90144c59ae1098d8fba95
@analysis-bot
Copy link

analysis-bot commented Sep 11, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,323,829 +28
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,562,522 +20
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 59e6b11
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068234

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 13, 2023
Summary:
Pull Request resolved: facebook#39351

In this diff I'm introducing the new WillBeDeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in
OSS.

changelog: [Android] Introduce WillBeDeprecatedInNewArchitecture annotation

Reviewed By: cortinico

Differential Revision: D49068234

fbshipit-source-id: 6ad14aa56db6b3401afed456535617bcd2d57635
@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against ddb996c

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068234

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 13, 2023
Summary:
Pull Request resolved: facebook#39351

In this diff I'm introducing the new WillBeDeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in
OSS.

changelog: [Android] Introduce WillBeDeprecatedInNewArchitecture annotation

Reviewed By: cortinico

Differential Revision: D49068234

fbshipit-source-id: 0c6aaf9cd7b7a46ef5347d1442d2d61b55005cbc
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068234

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 14, 2023
Summary:
Pull Request resolved: facebook#39351

In this diff I'm introducing the new WillBeDeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in
OSS.

changelog: [Android] Introduce WillBeDeprecatedInNewArchitecture annotation

Reviewed By: cortinico

Differential Revision: D49068234

fbshipit-source-id: 000b0373366890b912e633d16b044acc39bd7ec0
Differential Revision: D48992474

fbshipit-source-id: 054baa4609d62158f2ccff740e5bc0b338242222
Differential Revision: D48992720

fbshipit-source-id: 62b887eba709de20bc11d95acc8a99c78e854ac3
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068234

Summary:
Pull Request resolved: facebook#39351

In this diff I'm introducing the new WillBeDeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in
OSS.

changelog: [Android] Introduce WillBeDeprecatedInNewArchitecture annotation

Reviewed By: cortinico

Differential Revision: D49068234

fbshipit-source-id: 986b5f9e1d6b51a670746062459b317015cf31d8
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4fd44cd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants