Skip to content

【iOS】Fix Alert userInterfaceStyle having no effect #39346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zhongwuzw wants to merge 3 commits into from
Closed

【iOS】Fix Alert userInterfaceStyle having no effect #39346

zhongwuzw wants to merge 3 commits into from

Conversation

@zhongwuzw
Copy link
Contributor

@zhongwuzw zhongwuzw commented Sep 8, 2023

Summary:

Fixes #38852

Changelog:

[IOS] [FIXED] - Fix Alert userInterfaceStyle having no effect

Test Plan:

Run the demo from #38852 .

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 8, 2023
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 8, 2023

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@zhongwuzw
Copy link
Contributor Author

zhongwuzw commented Sep 8, 2023

@dmytrorykun I updated the commit to fix the lint.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 8, 2023

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cipolleschi
cipolleschi requested changes Sep 9, 2023
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment as we need to fix a double declaration that made our internal build fails.
Thank you for the time you are spending on this! 🙇

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 11, 2023

@dmytrorykun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cipolleschi
cipolleschi approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this!

cipolleschi
cipolleschi approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this!

@github-actions
Copy link

github-actions bot commented Sep 11, 2023

This pull request was successfully merged by @zhongwuzw in 0e150d0.

When will my fix make it into a release? | Upcoming Releases

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 11, 2023

@dmytrorykun merged this pull request in 0e150d0.

@github-actions github-actions bot added the Merged This PR has been merged. label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[iOS]: Alert userInterfaceStyle having no effect

3 participants

@zhongwuzw @facebook-github-bot @cipolleschi