Skip to content

decode urls before reencoding with NSURL #39344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philIip wants to merge 1 commit into from
Closed

decode urls before reencoding with NSURL #39344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/react-native/React/Base/RCTConvert.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,16 @@ + (NSURL *)NSURL:(id)json
}

@try { // NSURL has a history of crashing with bad input, so let's be safe
NSURL *URL = nil;

NSURL *URL = [NSURL URLWithString:path];
#if defined(__IPHONE_OS_VERSION_MAX_ALLOWED) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 170000
if (@available(iOS 17.0, *)) {
NSString *decodedPercentPath = [path stringByRemovingPercentEncoding];
URL = [NSURL URLWithString:decodedPercentPath encodingInvalidCharacters:YES];
}
#endif

URL = URL ?: [NSURL URLWithString:path];
if (URL.scheme) { // Was a well-formed absolute URL
return URL;
}
Expand Down