-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate HybridData with DoNotStrip #39342
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D48992474 fbshipit-source-id: d18b284efd6ccf84c49271e4fe35ca9fbc7804eb
Differential Revision: D48992720 fbshipit-source-id: 011686927e3a8c20bf9d4be21c17c36e6090ebe1
Summary: In this diff I'm introducing the new DeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in OSS. changelog: [Android] Introduce DeprecatedInNewArchitecture annotation Differential Revision: D49068234 fbshipit-source-id: 0f98775bfbd5291ba14723a95fb674428e42f188
…le instead Differential Revision: D48992719 fbshipit-source-id: 878b3d66126a7fee3ee73cc942659d1d9b6641d9
Summary: Mark ReactPackage.getModule as UnstableReactNativeAPI changelog: [internal] internal Differential Revision: D49068233 fbshipit-source-id: 7ab60798be92e48552aebafacfeb5c26f55ce17d
Summary: Fix lint warning in MainReactPackage, as reactModule could be null changelog: [internal] internal Differential Revision: D49077064 fbshipit-source-id: 87c76eda79d6e9f580e74746af285140029d1013
Summary: Annotate HybridData with DoNotStrip changelog: [intenral] internal Differential Revision: D49077065 fbshipit-source-id: b85f181216ea62a6532f7730b45273af2e129be9
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Sep 7, 2023
This pull request was exported from Phabricator. Differential Revision: D49077065 |
Base commit: eb5e7b2 |
This pull request has been merged in a629ac4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Annotate HybridData with DoNotStrip
changelog: [intenral] internal
Differential Revision: D49077065