Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate HybridData with DoNotStrip #39342

Closed
wants to merge 7 commits into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Sep 7, 2023

Summary:
Annotate HybridData with DoNotStrip

changelog: [intenral] internal

Differential Revision: D49077065

mdvacca and others added 7 commits September 7, 2023 15:50
Differential Revision: D48992474

fbshipit-source-id: d18b284efd6ccf84c49271e4fe35ca9fbc7804eb
Differential Revision: D48992720

fbshipit-source-id: 011686927e3a8c20bf9d4be21c17c36e6090ebe1
Summary:
In this diff I'm introducing the new DeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in
OSS.

changelog: [Android] Introduce DeprecatedInNewArchitecture annotation

Differential Revision: D49068234

fbshipit-source-id: 0f98775bfbd5291ba14723a95fb674428e42f188
…le instead

Differential Revision: D48992719

fbshipit-source-id: 878b3d66126a7fee3ee73cc942659d1d9b6641d9
Summary:
Mark ReactPackage.getModule as UnstableReactNativeAPI

changelog: [internal] internal

Differential Revision: D49068233

fbshipit-source-id: 7ab60798be92e48552aebafacfeb5c26f55ce17d
Summary:
Fix lint warning in MainReactPackage, as reactModule could be null

changelog: [internal] internal

Differential Revision: D49077064

fbshipit-source-id: 87c76eda79d6e9f580e74746af285140029d1013
Summary:
Annotate HybridData with DoNotStrip

changelog: [intenral] internal

Differential Revision: D49077065

fbshipit-source-id: b85f181216ea62a6532f7730b45273af2e129be9
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 7, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077065

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,964,578 -41
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,556,469 +51
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: eb5e7b2
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 14, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in a629ac4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants