Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lambdas to return reactModuleInfoMap #39341

Closed
wants to merge 10 commits into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Sep 7, 2023

Summary:
Use lambdas to return reactModuleInfoMap

changelog: [intenral] internal

Differential Revision: D49077067

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 7, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077067

@analysis-bot
Copy link

analysis-bot commented Sep 7, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,970,047 +153
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,563,373 +215
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 9faf256
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077067

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39341

Use lambdas to return reactModuleInfoMap

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077067

fbshipit-source-id: 2be547414326928438012fd33dfa55bd68adde94
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077067

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39341

Use lambdas to return reactModuleInfoMap

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077067

fbshipit-source-id: 9279d96144297368d1ec4533d2acb97a50b59c21
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077067

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39341

Use lambdas to return reactModuleInfoMap

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077067

fbshipit-source-id: a6ba4db160f966a3651ce765bb6cbfe7b5193c5b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077067

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39341

Use lambdas to return reactModuleInfoMap

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077067

fbshipit-source-id: 4cc8ed252d0758b7b7534d7d63a687b06c5df34c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077067

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 11, 2023
Summary:
Pull Request resolved: facebook#39341

Use lambdas to return reactModuleInfoMap

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077067

fbshipit-source-id: 078fb16581645e3a09fd254094fba78fac6fdce8
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077067

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 13, 2023
Summary:
Pull Request resolved: facebook#39341

Use lambdas to return reactModuleInfoMap

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077067

fbshipit-source-id: f7a7223958a269d9334b59d780d63090ad8b5155
@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 9cb79bf

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077067

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 13, 2023
Summary:
Pull Request resolved: facebook#39341

Use lambdas to return reactModuleInfoMap

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077067

fbshipit-source-id: 25138a0287d496dcfcbb90cbd61480f0a24a5b53
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077067

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 14, 2023
Summary:
Pull Request resolved: facebook#39341

Use lambdas to return reactModuleInfoMap

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077067

fbshipit-source-id: 6dffb24c35f364af0d5b81d57a9d684dacb24139
Differential Revision: D48992474

fbshipit-source-id: 696f320b787ce72d838a159b61f76d1c7ce40321
Differential Revision: D48992720

fbshipit-source-id: b0f9b0234c0906bf00e092925d06640425abb2fe
Summary:
In this diff I'm introducing the new DeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in
OSS.

changelog: [Android] Introduce DeprecatedInNewArchitecture annotation

Differential Revision: D49068234

fbshipit-source-id: 63ffe21ecdde39297d5cab855b1a7a221329e1d5
…le instead

Differential Revision: D48992719

fbshipit-source-id: 6748f6ba60df83c4fd37c4adc469e6fa0e103a14
Summary:
Mark ReactPackage.getModule as UnstableReactNativeAPI

changelog: [internal] internal

Differential Revision: D49068233

fbshipit-source-id: b568629f0e842e2f06ccd3ef02d5ffc66b709a0b
Summary:
Fix lint warning in MainReactPackage, as reactModule could be null

changelog: [internal] internal

Differential Revision: D49077064

fbshipit-source-id: 28982059e74a2870121ba2da6f606d74654da4c2
Summary:
Annotate HybridData with DoNotStrip

changelog: [intenral] internal

Differential Revision: D49077065

fbshipit-source-id: 4776831376d566346464d9ce8debacc026a6d147
Summary:
Reduce visibility of TurboModuleInteropUtils to package only

changelog: [intenral] internal

Differential Revision: D49077066

fbshipit-source-id: 08b1679b0fd60a46407ecbb5ceedc0b3d1b824ed
Summary:
Reduce visibility of TurboModulePerfLogger to pacakge and remove some lint warns

changelog: [intenral] internal

Differential Revision: D49077068

fbshipit-source-id: d454b948e01048e72727704175ff2b26264d9ddf
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077067

Summary:
Pull Request resolved: facebook#39341

Use lambdas to return reactModuleInfoMap

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077067

fbshipit-source-id: e36bb97d7db71f5aafdcf7528a82103379e781cc
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4b6fd81.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants