Fix lint warning #39338
Closed
Fix lint warning #39338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49077064 |
Base commit: 59e6b11 |
|
This pull request was exported from Phabricator. Differential Revision: D49077064 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 8, 2023
Summary: Pull Request resolved: facebook#39338 Fix lint warning in MainReactPackage, as reactModule could be null changelog: [internal] internal Reviewed By: cortinico Differential Revision: D49077064 fbshipit-source-id: 77ab4fde5392fa934db6648093bf778688616f6d
mdvacca
force-pushed
the
export-D49077064
branch
from
b7e3fb6
to
6d4c6fe
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 8, 2023
Summary: Pull Request resolved: facebook#39338 Fix lint warning in MainReactPackage, as reactModule could be null changelog: [internal] internal Reviewed By: cortinico Differential Revision: D49077064 fbshipit-source-id: b0f22f3acc46d6f5507239e27885146140b56883
mdvacca
force-pushed
the
export-D49077064
branch
from
6d4c6fe
to
ee109e7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49077064 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49077064 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 8, 2023
Summary: Pull Request resolved: facebook#39338 Fix lint warning in MainReactPackage, as reactModule could be null changelog: [internal] internal Reviewed By: cortinico Differential Revision: D49077064 fbshipit-source-id: eb4f11322d0759422d64601ec8a3edb105d2609b
mdvacca
force-pushed
the
export-D49077064
branch
from
ee109e7
to
80479ea
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49077064 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#39338 Fix lint warning in MainReactPackage, as reactModule could be null changelog: [internal] internal Reviewed By: cortinico Differential Revision: D49077064 fbshipit-source-id: 137570b4f6fe227e20e18fbae50c8a32026cd322
mdvacca
force-pushed
the
export-D49077064
branch
from
80479ea
to
5440041
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49077064 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 13, 2023
Summary: Pull Request resolved: facebook#39338 Fix lint warning in MainReactPackage, as reactModule could be null changelog: [internal] internal Reviewed By: cortinico Differential Revision: D49077064 fbshipit-source-id: 5bbb4484c76d90e3a7c8b6e1141aed8ee8a98fe1
mdvacca
force-pushed
the
export-D49077064
branch
from
5440041
to
563aac5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49077064 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 13, 2023
Summary: Pull Request resolved: facebook#39338 Fix lint warning in MainReactPackage, as reactModule could be null changelog: [internal] internal Reviewed By: cortinico Differential Revision: D49077064 fbshipit-source-id: 01dd079793ce9e25e022f910254814a86d08b6c8
mdvacca
force-pushed
the
export-D49077064
branch
from
563aac5
to
c39d7cb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49077064 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39338 Fix lint warning in MainReactPackage, as reactModule could be null changelog: [internal] internal Reviewed By: cortinico Differential Revision: D49077064 fbshipit-source-id: 22bbef287f0293fba94fcca3e8e0f4b6a375559d
mdvacca
force-pushed
the
export-D49077064
branch
from
c39d7cb
to
6ea4b5e
Compare
Differential Revision: D48992474 fbshipit-source-id: 18c365e43a30bc753d913460374448268f8d4e79
Differential Revision: D48992720 fbshipit-source-id: e63a04832c6e7294d409cc8f410e5e8ac5159fae
Summary: In this diff I'm introducing the new DeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in OSS. changelog: [Android] Introduce DeprecatedInNewArchitecture annotation Differential Revision: D49068234 fbshipit-source-id: 1fe70a02145989c38c08eb025ac46a60a645187a
…le instead Differential Revision: D48992719 fbshipit-source-id: 18783ab91244170eb5687f9f1d134bedf6da8285
Summary: Mark ReactPackage.getModule as UnstableReactNativeAPI changelog: [internal] internal Differential Revision: D49068233 fbshipit-source-id: 125aeded1ef261425cc6debd59564e14f3da410d
|
This pull request was exported from Phabricator. Differential Revision: D49077064 |
Summary: Pull Request resolved: facebook#39338 Fix lint warning in MainReactPackage, as reactModule could be null changelog: [internal] internal Reviewed By: cortinico Differential Revision: D49077064 fbshipit-source-id: a2fdb85bd104eb15f9e6fd198de369f0cd1df477
mdvacca
force-pushed
the
export-D49077064
branch
from
6ea4b5e
to
709062a
Compare
|
This pull request has been merged in fdae17d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix lint warning in MainReactPackage, as reactModule could be null
changelog: [internal] internal
Differential Revision: D49077064