Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ReactPackage.getModule as UnstableReactNativeAPI #39337

Closed
wants to merge 5 commits into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Sep 7, 2023

Summary:
Mark ReactPackage.getModule as UnstableReactNativeAPI

changelog: [internal] internal

Differential Revision: D49068233

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 7, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068233

@analysis-bot
Copy link

analysis-bot commented Sep 7, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,969,885 -9
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,563,160 +2
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 9faf256
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068233

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39337

Mark ReactPackage.getModule as UnstableReactNativeAPI

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D49068233

fbshipit-source-id: e28db8b8a1d615ae3ce9783f8c9c43bdf0eff7ba
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068233

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39337

Mark ReactPackage.getModule as UnstableReactNativeAPI

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D49068233

fbshipit-source-id: 2df02fd7c2ce91e92e11924870471941b8604c2c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068233

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39337

Mark ReactPackage.getModule as UnstableReactNativeAPI

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D49068233

fbshipit-source-id: 9da79208bc560ff4d8e443eed70fff4d70867fe2
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068233

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 11, 2023
Summary:
Pull Request resolved: facebook#39337

Mark ReactPackage.getModule as UnstableReactNativeAPI

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D49068233

fbshipit-source-id: 8cdce7602fadfe5ee463142d68b1f2bd8edb2678
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068233

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 13, 2023
Summary:
Pull Request resolved: facebook#39337

Mark ReactPackage.getModule as UnstableReactNativeAPI

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D49068233

fbshipit-source-id: 6d38a21453ca0e3d44d05539e92fb74f4bbbf74b
@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 2d5595c

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068233

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 13, 2023
Summary:
Pull Request resolved: facebook#39337

Mark ReactPackage.getModule as UnstableReactNativeAPI

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D49068233

fbshipit-source-id: 13b0905c07104faa094c51ec333791533782ab2d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068233

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 14, 2023
Summary:
Pull Request resolved: facebook#39337

Mark ReactPackage.getModule as UnstableReactNativeAPI

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D49068233

fbshipit-source-id: 7577a1c48b3e0a45477b92beb9a119b0099d67d3
Differential Revision: D48992474

fbshipit-source-id: eac42a51b9259211ba260f7ec456a7500da087f6
Differential Revision: D48992720

fbshipit-source-id: bb11772d6b571f91ea07740d7a406a9ba4ff3696
Summary:
In this diff I'm introducing the new DeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in
OSS.

changelog: [Android] Introduce DeprecatedInNewArchitecture annotation

Differential Revision: D49068234

fbshipit-source-id: 0817ff0055b0f964430e729c6b11af7ce1f765d2
…le instead

Differential Revision: D48992719

fbshipit-source-id: 3a2d31ad0d413b8fb7152f53a489c853a8dfdeb1
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49068233

Summary:
Pull Request resolved: facebook#39337

Mark ReactPackage.getModule as UnstableReactNativeAPI

changelog: [internal] internal

Reviewed By: arushikesarwani94

Differential Revision: D49068233

fbshipit-source-id: e9c3cda747f80e055a589625b7f585416df7c0b8
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ab806bd.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants