Add ReactPackage.getModule method #39336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48992720 |
Base commit: 9faf256 |
|
This pull request was exported from Phabricator. Differential Revision: D48992720 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 8, 2023
Summary: Pull Request resolved: facebook#39336 We are introducing the new getModule method into the ReactPackage interface following the "Registration of Native Modules" design This method defaults to true with the goal to avoid compatibility breakage changelog: [Android][Changed] Introducing getModule method into ReactPackage interface, defaulting to null. This method will be used in the Stable API of React Native Reviewed By: cortinico Differential Revision: D48992720 fbshipit-source-id: 3e6bb8433f123397b20127d47393f45c92a2c795
mdvacca
force-pushed
the
export-D48992720
branch
from
9ec2bd0
to
8175570
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48992720 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 8, 2023
Summary: Pull Request resolved: facebook#39336 We are introducing the new getModule method into the ReactPackage interface following the "Registration of Native Modules" design This method defaults to true with the goal to avoid compatibility breakage changelog: [Android][Changed] Introducing getModule method into ReactPackage interface, defaulting to null. This method will be used in the Stable API of React Native Reviewed By: cortinico Differential Revision: D48992720 fbshipit-source-id: 7b564cf23d919b2279bd0456c89c77ce344720d0
mdvacca
force-pushed
the
export-D48992720
branch
from
8175570
to
35167a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48992720 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 8, 2023
Summary: Pull Request resolved: facebook#39336 We are introducing the new getModule method into the ReactPackage interface following the "Registration of Native Modules" design This method defaults to true with the goal to avoid compatibility breakage changelog: [Android][Changed] Introducing getModule method into ReactPackage interface, defaulting to null. This method will be used in the Stable API of React Native Reviewed By: cortinico Differential Revision: D48992720 fbshipit-source-id: 58d77e22cf62a90c0a63145cb4c5c768317438c2
mdvacca
force-pushed
the
export-D48992720
branch
from
35167a1
to
267b761
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48992720 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 11, 2023
Summary: Pull Request resolved: facebook#39336 We are introducing the new getModule method into the ReactPackage interface following the "Registration of Native Modules" design This method defaults to true with the goal to avoid compatibility breakage changelog: [Android][Changed] Introducing getModule method into ReactPackage interface, defaulting to null. This method will be used in the Stable API of React Native Reviewed By: cortinico Differential Revision: D48992720 fbshipit-source-id: aba274356f554d4de040afb5fb538d91521f1fd2
mdvacca
force-pushed
the
export-D48992720
branch
from
267b761
to
fb416a4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48992720 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 13, 2023
Summary: Pull Request resolved: facebook#39336 We are introducing the new getModule method into the ReactPackage interface following the "Registration of Native Modules" design This method defaults to true with the goal to avoid compatibility breakage changelog: [Android][Changed] Introducing getModule method into ReactPackage interface, defaulting to null. This method will be used in the Stable API of React Native Reviewed By: cortinico Differential Revision: D48992720 fbshipit-source-id: dfd6673669cdee4d2da8b2e1f01ec61abeeb5037
mdvacca
force-pushed
the
export-D48992720
branch
from
fb416a4
to
df1e3a2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48992720 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 13, 2023
Summary: Pull Request resolved: facebook#39336 We are introducing the new getModule method into the ReactPackage interface following the "Registration of Native Modules" design This method defaults to true with the goal to avoid compatibility breakage changelog: [Android][Changed] Introducing getModule method into ReactPackage interface, defaulting to null. This method will be used in the Stable API of React Native Reviewed By: cortinico Differential Revision: D48992720 fbshipit-source-id: 5a44b795b2e8032c8b865acc12325616ece060ee
mdvacca
force-pushed
the
export-D48992720
branch
from
df1e3a2
to
81b15be
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48992720 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 14, 2023
Summary: Pull Request resolved: facebook#39336 We are introducing the new getModule method into the ReactPackage interface following the "Registration of Native Modules" design This method defaults to true with the goal to avoid compatibility breakage changelog: [Android][Changed] Introducing getModule method into ReactPackage interface, defaulting to null. This method will be used in the Stable API of React Native Reviewed By: cortinico Differential Revision: D48992720 fbshipit-source-id: 561f46f5db8370ded1e63465fa69fe657d6a4429
mdvacca
force-pushed
the
export-D48992720
branch
from
81b15be
to
2e2a9a3
Compare
Differential Revision: D48992474 fbshipit-source-id: 104e6a2530837836dabb5914836cb6ba969ab5a7
|
This pull request was exported from Phabricator. Differential Revision: D48992720 |
Summary: Pull Request resolved: facebook#39336 We are introducing the new getModule method into the ReactPackage interface following the "Registration of Native Modules" design This method defaults to true with the goal to avoid compatibility breakage changelog: [Android][Changed] Introducing getModule method into ReactPackage interface, defaulting to null. This method will be used in the Stable API of React Native Reviewed By: cortinico Differential Revision: D48992720 fbshipit-source-id: 704c03dfa508b3cb10837f8256c8b15a54a25c6e
mdvacca
force-pushed
the
export-D48992720
branch
from
2e2a9a3
to
748d9c5
Compare
|
This pull request has been merged in da8616e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We are introducing the new getModule method into the ReactPackage interface following the "Registration of Native Modules" design
This method defaults to true with the goal to avoid compatibility breakage
changelog: [Android][Changed] Introducing getModule method into ReactPackage interface, defaulting to null. This method will be used in the Stable API of React Native
Differential Revision: D48992720