Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JSC] Remove redundant ifdefs for ArrayBuffer backwards compatibility #39302

Closed
wants to merge 1 commit into from

Conversation

Saadnajmi
Copy link
Contributor

@Saadnajmi Saadnajmi commented Sep 5, 2023

Summary:

We're well past a minimum iOS 10 / macOS 10.11 version. Let's remove these ifdefs that seemed to have been added for backwards compatibility around the use of ArrayBuffers

Changelog:

[IOS] [REMOVED] - Remove redundant ifdefs for ArrayBuffer backwards compatibility

Test Plan:

CI should pass.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Sep 5, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,962,451 -232
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,554,196 -447
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 5258f3a
Branch: main

@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@javache merged this pull request in fb30fca.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Sep 6, 2023
@Saadnajmi Saadnajmi deleted the array-buffers branch September 6, 2023 14:36
Saadnajmi added a commit to Saadnajmi/react-native-macos that referenced this pull request Sep 6, 2023
…book#39302)

Summary:
We're well past a minimum iOS 10 / macOS 10.11 version. Let's remove these ifdefs that seemed to have been added for backwards compatibility around the use of [ArrayBuffers](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer)

## Changelog:

[IOS] [REMOVED] - Remove redundant ifdefs for ArrayBuffer backwards compatibility

Pull Request resolved: facebook#39302

Test Plan: CI should pass.

Reviewed By: rshest

Differential Revision: D49007666

Pulled By: javache

fbshipit-source-id: 03ebe303eda45ce043e3c2f9e2a5165ba798b15c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Microsoft Partner: Microsoft Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants