Fix backfaceVisibility after transform changes #39294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48968421 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 5, 2023
Summary: Because we now apply the transform property after all properties have been applied, the [custom logic we have for backfaceVisibility](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java#L1004) no longer applied correctly. Changelog: [Fixed] backfaceVisibility is correctly applied again after the transform changes. Reviewed By: fabriziocucci Differential Revision: D48968421
javache
force-pushed
the
export-D48968421
branch
from
8277453
to
a535e7d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48968421 |
Base commit: 4bc089a |
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 5, 2023
Summary: Because we now apply the transform property after all properties have been applied, the [custom logic we have for backfaceVisibility](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java#L1004) no longer applied correctly. Changelog: [Fixed] backfaceVisibility is correctly applied again after the transform changes. Reviewed By: fabriziocucci Differential Revision: D48968421
javache
force-pushed
the
export-D48968421
branch
from
a535e7d
to
1bcd8dc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48968421 |
Summary: Because we now apply the transform property after all properties have been applied, the [custom logic we have for backfaceVisibility](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java#L1004) no longer applied correctly. Changelog: [Fixed] backfaceVisibility is correctly applied again after the transform changes. Reviewed By: fabriziocucci Differential Revision: D48968421
|
This pull request was exported from Phabricator. Differential Revision: D48968421 |
javache
force-pushed
the
export-D48968421
branch
from
1bcd8dc
to
06e394d
Compare
|
This pull request has been merged in 242c835. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Because we now apply the transform property after all properties have been applied, the custom logic we have for backfaceVisibility no longer applied correctly.
Changelog: [Fixed] backfaceVisibility is correctly applied again after the transform changes.
Reviewed By: fabriziocucci
Differential Revision: D48968421