Revert to built-in devToolsFrontendUrl in target list #39242
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Reverts external behaviour of facebook#39122. - `/json/list` once again returns the built-in `devtools://devtools/bundled/js_app.html` URL — effectively freezing the current experience in Flipper. - `/open-debugger` continues to use the *new* frontend via `getDevToolsFrontendUrl`. - *Eventually*, we'll want to align this as the returned `devtoolsFrontendUrl` value once Flipper is out of the picture. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48868767 fbshipit-source-id: 26405f57e396c00957b5345dc21c4d8bd920edcf
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48868767 |
|
This pull request has been merged in a5fd0f1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reverts external behaviour of #39122.
/json/listonce again returns the built-indevtools://devtools/bundled/js_app.htmlURL — effectively freezing the current experience in Flipper./open-debuggercontinues to use the new frontend viagetDevToolsFrontendUrl.devtoolsFrontendUrlvalue once Flipper is out of the picture.Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D48868767