Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CI check jobs on .flowconfig.android in react-native #39158

Closed
wants to merge 1 commit into from
Closed

Remove CI check jobs on .flowconfig.android in react-native #39158

wants to merge 1 commit into from

Conversation

SamChou19815
Copy link
Contributor

Summary:
.flowconfig.android is the same as .flowconfig in xplat now. The check is meaningless. This diff removes it and the flowconfig.

Changelog: [Internal]

Differential Revision: D48629137

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Aug 25, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48629137

@analysis-bot
Copy link

analysis-bot commented Aug 25, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,960,676 +1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,554,764 +18
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 31bfed3
Branch: main

@github-actions
Copy link

github-actions bot commented Aug 25, 2023

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 09382b0

Summary:
Pull Request resolved: #39158

.flowconfig.android is the same as .flowconfig now. The check is meaningless. This diff removes it and the flowconfig.

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D48629137

fbshipit-source-id: 2dec6e0f8c1ca93f8b7097230f7fc3b701067eed
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48629137

@github-actions
Copy link

This pull request was successfully merged by @SamChou19815 in 246b5cf.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Aug 26, 2023
@SamChou19815 SamChou19815 deleted the export-D48629137 branch August 26, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants