Emit warning when props parsing encounters inconsistent duplicate keys #39149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48641819 |
Base commit: a0a544f |
|
This pull request was exported from Phabricator. Differential Revision: D48641819 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Aug 24, 2023
facebook#39149) Summary: Pull Request resolved: facebook#39149 Props structs are allowed to references RawValue keys multiple times, however this didn't work correctly if the key was formed out of a different combination of prefix/name/suffix, as the duplicate key entry would've been removed from the `RawPropsKeyMap`. Log an error in such scenarios to help identify these types of problems. Changelog: [Internal] Reviewed By: fabriziocucci Differential Revision: D48641819 fbshipit-source-id: f616bbf0c719d75ea5d1c0958355d1c3aa12dce0
javache
force-pushed
the
export-D48641819
branch
from
d374939
to
3420e3e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48641819 |
javache
force-pushed
the
export-D48641819
branch
from
3420e3e
to
d8e2831
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Aug 25, 2023
facebook#39149) Summary: Pull Request resolved: facebook#39149 Props structs are allowed to references RawValue keys multiple times, however this didn't work correctly if the key was formed out of a different combination of prefix/name/suffix, as the duplicate key entry would've been removed from the `RawPropsKeyMap`. Log an error in such scenarios to help identify these types of problems. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D48641819 fbshipit-source-id: 8470233ce47203ff18bd3a229e2b644289662bfb
|
This pull request was exported from Phabricator. Differential Revision: D48641819 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Aug 25, 2023
facebook#39149) Summary: Pull Request resolved: facebook#39149 Props structs are allowed to references RawValue keys multiple times, however this didn't work correctly if the key was formed out of a different combination of prefix/name/suffix, as the duplicate key entry would've been removed from the `RawPropsKeyMap`. Log an error in such scenarios to help identify these types of problems. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D48641819 fbshipit-source-id: 6b68480b0646a5598de2413de30aa817f354f2fc
javache
force-pushed
the
export-D48641819
branch
from
d8e2831
to
1612af7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48641819 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Aug 25, 2023
facebook#39149) Summary: Pull Request resolved: facebook#39149 Props structs are allowed to references RawValue keys multiple times, however this didn't work correctly if the key was formed out of a different combination of prefix/name/suffix, as the duplicate key entry would've been removed from the `RawPropsKeyMap`. Log an error in such scenarios to help identify these types of problems. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D48641819 fbshipit-source-id: 6ece6c54384e55c4688ccebac0f99932873dc8a7
javache
force-pushed
the
export-D48641819
branch
from
1612af7
to
86df577
Compare
facebook#39149) Summary: Pull Request resolved: facebook#39149 Props structs are allowed to references RawValue keys multiple times, however this didn't work correctly if the key was formed out of a different combination of prefix/name/suffix, as the duplicate key entry would've been removed from the `RawPropsKeyMap`. Log an error in such scenarios to help identify these types of problems. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D48641819 fbshipit-source-id: 33581fbbd6bd7cb3ed9fe76abd92c40795ff4853
|
This pull request was exported from Phabricator. Differential Revision: D48641819 |
javache
force-pushed
the
export-D48641819
branch
from
86df577
to
ae33fbd
Compare
|
This pull request was successfully merged by @javache in 3c87455. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Props structs are allowed to references RawValue keys multiple times, however this didn't work correctly if the key was formed out of a different combination of prefix/name/suffix, as the duplicate key entry would've been removed from the
RawPropsKeyMap. Log an error in such scenarios to help identify these types of problems.Changelog: [Internal]
Reviewed By: fabriziocucci
Differential Revision: D48641819