Provide more context when shadow tree ops (StubViewTree) consistency error reporting #39144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error reporting Summary: ## Changelog: [Internal] - This adds more information into internal shadow tree consistency check error reporting, as well as some minor code refactorings. Note that the code is run only in debug, and normally you don't trigger such issues, unless you look into a new platform implementation (which I did). Differential Revision: D48643602 fbshipit-source-id: 87019c0af51bd57cff4da67c8708a55410a97157
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48643602 |
Base commit: 4b664fc |
|
This pull request was successfully merged by @rshest in 18c4cb1. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in 18c4cb1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
This adds more information into internal shadow tree consistency check error reporting, as well as some minor code refactorings.
Note that the code is run only in debug, and normally you don't trigger such issues, unless you look into a new platform implementation (which I did).
Differential Revision: D48643602