Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlinfy ReactNativeConfig #39142

Closed

Conversation

arushikesarwani94
Copy link
Contributor

Summary:
X-link: facebookresearch/playtorch#227

ReactNativeConfig.java -> ReactNativeConfig.kt

changelog: [internal] internal

Differential Revision: D48585508

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 24, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48585508

@analysis-bot
Copy link

analysis-bot commented Aug 24, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,965,868 +324
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,554,384 -31
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 380bff9
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48585508

arushikesarwani94 added a commit to arushikesarwani94/react-native that referenced this pull request Aug 24, 2023
Summary:
Pull Request resolved: facebook#39142

X-link: facebookresearch/playtorch#227

`ReactNativeConfig.java` -> `ReactNativeConfig.kt`

changelog: [internal] internal

Reviewed By: rshest

Differential Revision: D48585508

fbshipit-source-id: 61899f761d7de62f7ec7179b0ee5eb0aa2ed9860
Summary:
Pull Request resolved: facebook#39142

X-link: facebookresearch/playtorch#227

`ReactNativeConfig.java` -> `ReactNativeConfig.kt`

changelog: [internal] internal

Reviewed By: rshest

Differential Revision: D48585508

fbshipit-source-id: 96929681b7009be6b6a3fac72b492adf6dbd71bd
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48585508

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in d5b656c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants