Make TurboReactPackage.getModule no nullable #39140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48588375 |
|
This pull request was exported from Phabricator. Differential Revision: D48588375 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: facebook#39140 TurboReactPackage.getModule is nullable, although the internals of ReactNative requires this method to be non null (otherwise there will a NPEs) I'm making TurboReactPackage.getModule no nullable, this is important to simplify API and future migration to kotlin changelog: [internal] internal/ Reviewed By: cortinico Differential Revision: D48588375 fbshipit-source-id: 2bf57c1b921a383c1a109b8ac9680e8bb8258ac6
mdvacca
force-pushed
the
export-D48588375
branch
from
9f46ad6
to
8d5ecdb
Compare
Base commit: 8955bfb |
Summary: getNativeModuleIterator is not required to be public, reducing visibillity to package only changelog: [internal] intenral Differential Revision: D48588376 fbshipit-source-id: 5e268184a1e6fa0d5ac1c17c88316513b7133db6
Summary: EZ cleanup of TurboReactPackage changelog: [internal] internal Differential Revision: D48588377 fbshipit-source-id: 0bda52a851d129b86eb32abfea07f17bc7eeee85
|
This pull request was exported from Phabricator. Differential Revision: D48588375 |
Summary: Pull Request resolved: facebook#39140 TurboReactPackage.getModule is nullable, although the internals of ReactNative requires this method to be non null (otherwise there will a NPEs) I'm making TurboReactPackage.getModule no nullable, this is important to simplify API and future migration to kotlin changelog: [internal] internal/ Reviewed By: cortinico Differential Revision: D48588375 fbshipit-source-id: ccd12c403b9d1c1ab1e22a4038ddbfd689fcf354
mdvacca
force-pushed
the
export-D48588375
branch
from
8d5ecdb
to
986a1e7
Compare
|
This pull request has been merged in 7eacf27. |
|
This pull request has been reverted by c46858a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
TurboReactPackage.getModule is nullable, although the internals of ReactNative requires this method to be non null (otherwise there will a NPEs)
I'm making TurboReactPackage.getModule no nullable, this is important to simplify API and future migration to kotlin
changelog: [internal] internal/
Reviewed By: cortinico
Differential Revision: D48588375