Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZ cleanup of TurboReactPackage #39139

Closed
wants to merge 2 commits into from
Closed

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Aug 23, 2023

Summary:
EZ cleanup of TurboReactPackage

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D48588377

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Aug 23, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48588377

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48588377

mdvacca added a commit to mdvacca/react-native that referenced this pull request Aug 23, 2023
Summary:
Pull Request resolved: facebook#39139

EZ cleanup of TurboReactPackage

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D48588377

fbshipit-source-id: 34e0a925a7ec641b79ad0e24719dd129d39c7e03
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48588377

mdvacca added a commit to mdvacca/react-native that referenced this pull request Aug 23, 2023
Summary:
Pull Request resolved: facebook#39139

EZ cleanup of TurboReactPackage

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D48588377

fbshipit-source-id: 4a2243fcab7a740a107ed4f70d30b295d43569c9
@analysis-bot
Copy link

analysis-bot commented Aug 23, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,959,342 -192
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,554,387 +88
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 8955bfb
Branch: main

Summary:
getNativeModuleIterator is not required to be public, reducing visibillity to package only

changelog: [internal] intenral

Differential Revision: D48588376

fbshipit-source-id: 342f42dc14f8aebbdde3ee266c1c495602ba724b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48588377

Summary:
Pull Request resolved: facebook#39139

EZ cleanup of TurboReactPackage

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D48588377

fbshipit-source-id: 13a2fe23a0ef46ce84e3bb6dbd73d73d07239cc1
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 42a7777.

@facebook-github-bot facebook-github-bot added Merged This PR has been merged. Reverted labels Aug 24, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by e7168c4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner Reverted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants