reduce visibility of getNativeModuleIterator #39137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48588376 |
|
This pull request was exported from Phabricator. Differential Revision: D48588376 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: facebook#39137 getNativeModuleIterator is not required to be public, reducing visibillity to package only changelog: [internal] intenral Differential Revision: D48588376 fbshipit-source-id: 94177d5c7c2fb2ec5e68f091eb1e836ae2601860
mdvacca
force-pushed
the
export-D48588376
branch
from
72ec4b3
to
a8ab449
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48588376 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: facebook#39137 getNativeModuleIterator is not required to be public, reducing visibillity to package only changelog: [internal] intenral Differential Revision: D48588376 fbshipit-source-id: f2cd3a8e47fd3f2965a24f0d34d87aae60edee91
mdvacca
force-pushed
the
export-D48588376
branch
from
a8ab449
to
9afc6d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48588376 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: facebook#39137 getNativeModuleIterator is not required to be public, reducing visibillity to package only changelog: [internal] intenral Differential Revision: D48588376 fbshipit-source-id: 27f2b7ff745f100e2380a6ad29ba10dda11a54dd
mdvacca
force-pushed
the
export-D48588376
branch
from
9afc6d6
to
6a5eddf
Compare
Base commit: 8955bfb |
|
This pull request was exported from Phabricator. Differential Revision: D48588376 |
Summary: Pull Request resolved: facebook#39137 getNativeModuleIterator is not required to be public, reducing visibillity to package only changelog: [internal] intenral Reviewed By: philIip, rshest Differential Revision: D48588376 fbshipit-source-id: ba450e6f3ad492575ddaf9c723a26332c6000e96
mdvacca
force-pushed
the
export-D48588376
branch
from
6a5eddf
to
d7b50bd
Compare
|
This pull request was successfully merged by @mdvacca in 40c1395. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in 40c1395. |
|
This pull request has been reverted by a0a544f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
getNativeModuleIterator is not required to be public, reducing visibillity to package only
changelog: [internal] intenral
Differential Revision: D48588376