Suport type aliases for TM getConstants() return type #39136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48620652 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#39136 ## Changelog: [Internal] - `getConstants()` method for TM was enforced to only use object literals for the return type specs. This limits flexibility, in particular those data structures can't be consequently exported and picked up by codegen (not even mentioning the potential need for copypasting those obejct literals around). This relaxes this restriction. Note that I've been digging into the development history in order to find out whether there was any particular historical reason for such a limitation, but couldn't find any, so I assume it was rather incidental. Differential Revision: https://internalfb.com/D48620652 fbshipit-source-id: fcfd0fd74c6313755c80a1233553aa694e7e18bd
|
This pull request was exported from Phabricator. Differential Revision: D48620652 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#39136 ## Changelog: [Internal] - `getConstants()` method for TM was enforced to only use object literals for the return type specs. This limits flexibility, in particular those data structures can't be consequently exported and picked up by codegen (not even mentioning the potential need for copypasting those obejct literals around). This relaxes this restriction. Note that I've been digging into the development history in order to find out whether there was any particular historical reason for such a limitation, but couldn't find any, so I assume it was rather incidental. Reviewed By: christophpurrer Differential Revision: D48620652 fbshipit-source-id: ea79ea139641d795c5d31239cb465289a793458e
rshest
force-pushed
the
export-D48620652
branch
from
5945f46
to
95f7e7e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48620652 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#39136 ## Changelog: [Internal] - `getConstants()` method for TM was enforced to only use object literals for the return type specs. This limits flexibility, in particular those data structures can't be consequently exported and picked up by codegen (not even mentioning the potential need for copypasting those obejct literals around). This relaxes this restriction. Note that I've been digging into the development history in order to find out whether there was any particular historical reason for such a limitation, but couldn't find any, so I assume it was rather incidental. Reviewed By: christophpurrer Differential Revision: D48620652 fbshipit-source-id: d4bd08d1fa82244dd739620c11409bd0355c6385
rshest
force-pushed
the
export-D48620652
branch
from
95f7e7e
to
258448a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48620652 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#39136 ## Changelog: [Internal] - `getConstants()` method for TM was enforced to only use object literals for the return type specs. This limits flexibility, in particular those data structures can't be consequently exported and picked up by codegen (not even mentioning the potential need for copypasting those obejct literals around). This relaxes this restriction. Note that I've been digging into the development history in order to find out whether there was any particular historical reason for such a limitation, but couldn't find any, so I assume it was rather incidental. Reviewed By: christophpurrer Differential Revision: D48620652 fbshipit-source-id: 2ba410d9410fc59077b5f73babafa1158a68a79b
rshest
force-pushed
the
export-D48620652
branch
from
258448a
to
75cc5d9
Compare
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#39136 ## Changelog: [Internal] - `getConstants()` method for TM was enforced to only use object literals for the return type specs. This limits flexibility, in particular those data structures can't be consequently exported and picked up by codegen (not even mentioning the potential need for copypasting those obejct literals around). This relaxes this restriction. Note that I've been digging into the development history in order to find out whether there was any particular historical reason for such a limitation, but couldn't find any, so I assume it was rather incidental. Differential Revision: https://internalfb.com/D48620652 fbshipit-source-id: 752d448f2f3ae473c77d974252d59fe6894d4666
|
This pull request was exported from Phabricator. Differential Revision: D48620652 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#39136 ## Changelog: [Internal] - `getConstants()` method for TM was enforced to only use object literals for the return type specs. This limits flexibility, in particular those data structures can't be consequently exported and picked up by codegen (not even mentioning the potential need for copypasting those obejct literals around). This relaxes this restriction. Note that I've been digging into the development history in order to find out whether there was any particular historical reason for such a limitation, but couldn't find any, so I assume it was rather incidental. Reviewed By: christophpurrer Differential Revision: D48620652 fbshipit-source-id: bc2f9b99c64885d63a0ee51e6e0394d2ff5aaed0
rshest
force-pushed
the
export-D48620652
branch
from
75cc5d9
to
9fca5c1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48620652 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#39136 ## Changelog: [Internal] - `getConstants()` method for TM was enforced to only use object literals for the return type specs. This limits flexibility, in particular those data structures can't be consequently exported and picked up by codegen (not even mentioning the potential need for copypasting those obejct literals around). This relaxes this restriction. Note that I've been digging into the development history in order to find out whether there was any particular historical reason for such a limitation, but couldn't find any, so I assume it was rather incidental. Reviewed By: christophpurrer Differential Revision: D48620652 fbshipit-source-id: d9aecee65f00a3ed745df8551fb30496924c242d
rshest
force-pushed
the
export-D48620652
branch
from
9fca5c1
to
d55d891
Compare
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#39136 ## Changelog: [Internal] - `getConstants()` method for TM was enforced to only use object literals for the return type specs. This limits flexibility, in particular those data structures can't be consequently exported and picked up by codegen (not even mentioning the potential need for copypasting those obejct literals around). This relaxes this restriction. Note that I've been digging into the development history in order to find out whether there was any particular historical reason for such a limitation, but couldn't find any, so I assume it was rather incidental. Differential Revision: https://internalfb.com/D48620652 fbshipit-source-id: 3aac1beb72907b18c475792fc70cceef4eb74b1e
|
This pull request was exported from Phabricator. Differential Revision: D48620652 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#39136 ## Changelog: [Internal] - `getConstants()` method for TM was enforced to only use object literals for the return type specs. This limits flexibility, in particular those data structures can't be consequently exported and picked up by codegen (not even mentioning the potential need for copypasting those obejct literals around). This relaxes this restriction. Note that I've been digging into the development history in order to find out whether there was any particular historical reason for such a limitation, but couldn't find any, so I assume it was rather incidental. Reviewed By: christophpurrer Differential Revision: D48620652 fbshipit-source-id: 0d2e0a639356390e894865560bceecd2d5b589ad
rshest
force-pushed
the
export-D48620652
branch
from
d55d891
to
67a1ce9
Compare
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
Summary: Pull Request resolved: facebook#39136 ## Changelog: [Internal] - `getConstants()` method for TM was enforced to only use object literals for the return type specs. This limits flexibility, in particular those data structures can't be consequently exported and picked up by codegen (not even mentioning the potential need for copypasting those obejct literals around). This relaxes this restriction. Note that I've been digging into the development history in order to find out whether there was any particular historical reason for such a limitation, but couldn't find any, so I assume it was rather incidental. Differential Revision: https://internalfb.com/D48620652 fbshipit-source-id: 8c3debb35157de868b69d889bbf7224b278bbd80
Summary: Pull Request resolved: facebook#39136 ## Changelog: [Internal] - `getConstants()` method for TM was enforced to only use object literals for the return type specs. This limits flexibility, in particular those data structures can't be consequently exported and picked up by codegen (not even mentioning the potential need for copypasting those obejct literals around). This relaxes this restriction. Note that I've been digging into the development history in order to find out whether there was any particular historical reason for such a limitation, but couldn't find any, so I assume it was rather incidental. Reviewed By: christophpurrer Differential Revision: D48620652 fbshipit-source-id: 901b102ec90b43f41b75084ea57668d9c6a63ff6
|
This pull request was exported from Phabricator. Differential Revision: D48620652 |
rshest
force-pushed
the
export-D48620652
branch
from
67a1ce9
to
b05c4b9
Compare
|
This pull request has been merged in 3c6bf7b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
getConstants()method for TM was enforced to only use object literals for the return type specs.This limits flexibility, in particular those data structures can't be consequently exported and picked up by codegen (not even mentioning the potential need for copypasting those obejct literals around).
This relaxes this restriction.
Note that I've been digging into the development history in order to find out whether there was any particular historical reason for such a limitation, but couldn't find any, so I assume it was rather incidental.
Differential Revision: D48620652