Export DeviceInfoConstants type from the native module's specs #39135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48620784 |
|
This pull request was exported from Phabricator. Differential Revision: D48620784 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
…ook#39135) Summary: Pull Request resolved: facebook#39135 ## Changelog: [Internal] - Expose constants type from DeviceInfo native module - this makes codegen generate the corresponding data structure, making the native module implementation shorter (in C++ in particular). Reviewed By: christophpurrer Differential Revision: D48620784 fbshipit-source-id: 0d7907e677c7a2d8c24c808be3964ba87cef7d5e
rshest
force-pushed
the
export-D48620784
branch
from
bd51fd8
to
20a7ae1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48620784 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
…ook#39135) Summary: Pull Request resolved: facebook#39135 ## Changelog: [Internal] - Expose constants type from DeviceInfo native module - this makes codegen generate the corresponding data structure, making the native module implementation shorter (in C++ in particular). Reviewed By: christophpurrer Differential Revision: D48620784 fbshipit-source-id: 8e1fd40806c897261e156154ecd79fcc1fdce2f1
rshest
force-pushed
the
export-D48620784
branch
from
20a7ae1
to
f903fd7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48620784 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
…ook#39135) Summary: Pull Request resolved: facebook#39135 ## Changelog: [Internal] - Expose constants type from DeviceInfo native module - this makes codegen generate the corresponding data structure, making the native module implementation shorter (in C++ in particular). Reviewed By: christophpurrer Differential Revision: D48620784 fbshipit-source-id: 927020b3ad3301d63cca2a2332ae7bc3231acda4
rshest
force-pushed
the
export-D48620784
branch
from
f903fd7
to
e7dcdd9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48620784 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
…ook#39135) Summary: Pull Request resolved: facebook#39135 ## Changelog: [Internal] - Expose constants type from DeviceInfo native module - this makes codegen generate the corresponding data structure, making the native module implementation shorter (in C++ in particular). Reviewed By: christophpurrer Differential Revision: D48620784 fbshipit-source-id: 02fca58481b7f75933b10e9831007b0025de5cee
rshest
force-pushed
the
export-D48620784
branch
from
e7dcdd9
to
8bdc94c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48620784 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
…ook#39135) Summary: Pull Request resolved: facebook#39135 ## Changelog: [Internal] - Expose constants type from DeviceInfo native module - this makes codegen generate the corresponding data structure, making the native module implementation shorter (in C++ in particular). Reviewed By: christophpurrer Differential Revision: D48620784 fbshipit-source-id: 27f37f0cc06478a8e9665fbc03cd2b9dadd1e8dc
rshest
force-pushed
the
export-D48620784
branch
from
8bdc94c
to
c306986
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48620784 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
…ook#39135) Summary: Pull Request resolved: facebook#39135 ## Changelog: [Internal] - Expose constants type from DeviceInfo native module - this makes codegen generate the corresponding data structure, making the native module implementation shorter (in C++ in particular). Reviewed By: christophpurrer Differential Revision: D48620784 fbshipit-source-id: dc904f75a8a5fa13c2b24a74b3bc7db77fb7492f
rshest
force-pushed
the
export-D48620784
branch
from
c306986
to
3ad8058
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48620784 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
…ook#39135) Summary: Pull Request resolved: facebook#39135 ## Changelog: [Internal] - Expose constants type from DeviceInfo native module - this makes codegen generate the corresponding data structure, making the native module implementation shorter (in C++ in particular). Reviewed By: christophpurrer Differential Revision: D48620784 fbshipit-source-id: bb700b8d75313ccdc82f0b2c94fd98468ad3c563
rshest
force-pushed
the
export-D48620784
branch
from
3ad8058
to
f23be82
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48620784 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
…ook#39135) Summary: Pull Request resolved: facebook#39135 ## Changelog: [Internal] - Expose constants type from DeviceInfo native module - this makes codegen generate the corresponding data structure, making the native module implementation shorter (in C++ in particular). Reviewed By: christophpurrer Differential Revision: D48620784 fbshipit-source-id: d0ee6de1d5e3b8d9449c05bfce2710a62960cdb7
rshest
force-pushed
the
export-D48620784
branch
from
f23be82
to
204379a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48620784 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
…ook#39135) Summary: Pull Request resolved: facebook#39135 ## Changelog: [Internal] - Expose constants type from DeviceInfo native module - this makes codegen generate the corresponding data structure, making the native module implementation shorter (in C++ in particular). Reviewed By: christophpurrer Differential Revision: D48620784 fbshipit-source-id: 91224d66a7ae2623da6f577da8a736efd4197dda
rshest
force-pushed
the
export-D48620784
branch
from
204379a
to
3c2faef
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48620784 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
…ook#39135) Summary: Pull Request resolved: facebook#39135 ## Changelog: [Internal] - Expose constants type from DeviceInfo native module - this makes codegen generate the corresponding data structure, making the native module implementation shorter (in C++ in particular). Reviewed By: christophpurrer Differential Revision: D48620784 fbshipit-source-id: b95725c5f5a454b47816114e4d524aab8081efd0
rshest
force-pushed
the
export-D48620784
branch
from
3c2faef
to
aeea0f8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48620784 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
…ook#39135) Summary: Pull Request resolved: facebook#39135 ## Changelog: [Internal] - Expose constants type from DeviceInfo native module - this makes codegen generate the corresponding data structure, making the native module implementation shorter (in C++ in particular). Reviewed By: christophpurrer Differential Revision: D48620784 fbshipit-source-id: a89f4fd49586ca20900a11f53c0ee152dbbcb1a8
rshest
force-pushed
the
export-D48620784
branch
from
aeea0f8
to
94b308d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48620784 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
…ook#39135) Summary: Pull Request resolved: facebook#39135 ## Changelog: [Internal] - Expose constants type from DeviceInfo native module - this makes codegen generate the corresponding data structure, making the native module implementation shorter (in C++ in particular). Reviewed By: christophpurrer Differential Revision: D48620784 fbshipit-source-id: 4397e339e22aa1747b2f1197bd8cf148b0081ad9
rshest
force-pushed
the
export-D48620784
branch
from
94b308d
to
d674930
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48620784 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Aug 24, 2023
…ook#39135) Summary: Pull Request resolved: facebook#39135 ## Changelog: [Internal] - Expose constants type from DeviceInfo native module - this makes codegen generate the corresponding data structure, making the native module implementation shorter (in C++ in particular). Reviewed By: christophpurrer Differential Revision: D48620784 fbshipit-source-id: d9e4f275c3cb3e4d24d9d6a7ea72bbb72c7bcf4e
rshest
force-pushed
the
export-D48620784
branch
from
d674930
to
473fb23
Compare
…ook#39135) Summary: Pull Request resolved: facebook#39135 ## Changelog: [Internal] - Expose constants type from DeviceInfo native module - this makes codegen generate the corresponding data structure, making the native module implementation shorter (in C++ in particular). Reviewed By: christophpurrer Differential Revision: D48620784 fbshipit-source-id: 7f27d18757268486801fd7df958893e572c6bdd5
|
This pull request was exported from Phabricator. Differential Revision: D48620784 |
rshest
force-pushed
the
export-D48620784
branch
from
473fb23
to
ac0deef
Compare
|
This pull request has been merged in 8955bfb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] -
Expose constants type from DeviceInfo native module - this makes codegen generate the corresponding data structure, making the native module implementation shorter (in C++ in particular).
Differential Revision: D48620784