Fix PROJECT_ROOT for RNTester Xcode project #39112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48526552 |
Base commit: 3c943bb |
Summary: Pull Request resolved: facebook#39112 RNTester's `PROJECT_ROOT` should point to `packages/rn-tester` but for some reason it points to the `react-native` monorepo root. Changelog: [iOS][Fixed] - RNTester's PROJECT_ROOT points to `packages/rn-tester` Reviewed By: cipolleschi Differential Revision: D48526552 fbshipit-source-id: 78fa4e047c69783dfd79d60cc57a8755f3f39d28
|
This pull request was exported from Phabricator. Differential Revision: D48526552 |
dmytrorykun
force-pushed
the
export-D48526552
branch
from
18613b0
to
3175ac8
Compare
|
This pull request was successfully merged by @dmytrorykun in cd30bc3. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in cd30bc3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
RNTester's
PROJECT_ROOTshould point topackages/rn-testerbut for some reason it points to thereact-nativemonorepo root.Changelog: [iOS][Fixed] - RNTester's PROJECT_ROOT points to
packages/rn-testerDifferential Revision: D48526552