Fix bad comparison in RCTScrollViewComponentView RTL #39030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48378414 |
Base commit: 676676c |
Summary: Pull Request resolved: facebook#39030 D29164056 fixed `scrollTo` coordinate space in RTL, but D38499666 regressed it by adding a comparison before the RTL conversion happens. This makes `scrollTo` no-op if we are scrolling from the beginning to the end of the list, since the end of the list is `x: 0` in cartesian coordinates, and the start of the list is `x: 0` in flow-relative coordinates. Do coordinate conversion before the early exit check. Changelog: [iOS][Fixed] - Fix bad comparison in RCTScrollViewComponentView RTL Reviewed By: rshest Differential Revision: D48378414 fbshipit-source-id: 4ec9bde1a2f9910f35f4035db008bb8d2e2d6f89
|
This pull request was exported from Phabricator. Differential Revision: D48378414 |
NickGerleman
force-pushed
the
export-D48378414
branch
from
285115f
to
af36cc0
Compare
|
This pull request has been merged in 65b7680. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
D29164056 fixed
scrollTocoordinate space in RTL, but D38499666 regressed it by adding a comparison before the RTL conversion happens.This makes
scrollTono-op if we are scrolling from the beginning to the end of the list, since the end of the list isx: 0in cartesian coordinates, and the start of the list isx: 0in flow-relative coordinates.Do coordinate conversion before the early exit check.
Changelog:
[iOS][Fixed] - Fix bad comparison in RCTScrollViewComponentView RTL
Differential Revision: D48378414