Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete hasBridge from hosting view api #38870

Closed
wants to merge 1 commit into from

Conversation

philIip
Copy link
Contributor

@philIip philIip commented Aug 9, 2023

Summary:
Changelog: [Internal]

i'm looking to limit callsites to the bridge in new architecture. in GH search i didn't see anyone using this method.

Differential Revision: D48175886

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Aug 9, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48175886

@analysis-bot
Copy link

analysis-bot commented Aug 9, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,895,334 +1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,487,025 +0
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: baa2714
Branch: main

philIip added a commit to philIip/react-native that referenced this pull request Aug 9, 2023
Summary:
Pull Request resolved: facebook#38870

Changelog: [iOS][Breaking]

i'm looking to limit callsites to the bridge in new architecture. in GH search i didn't see anyone using this method.

Differential Revision: D48175886

fbshipit-source-id: c896ecaa6134bb1d7209096c2f3d5ebdb5189916
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48175886

philIip added a commit to philIip/react-native that referenced this pull request Aug 9, 2023
Summary:
Pull Request resolved: facebook#38870

Changelog: [iOS][Breaking]

i'm looking to limit callsites to the bridge in new architecture. in GH search i didn't see anyone using this method.

Differential Revision: D48175886

fbshipit-source-id: ce9b3dd7b721ee919f71711e06830ab35fe3037d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48175886

philIip added a commit to philIip/react-native that referenced this pull request Aug 9, 2023
Summary:
Pull Request resolved: facebook#38870

Changelog: [iOS][Breaking]

i'm looking to limit callsites to the bridge in new architecture. in GH search i didn't see anyone using this method.

Differential Revision: D48175886

fbshipit-source-id: ef921b181832ce58c75dc4357d96318b60afd795
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48175886

philIip added a commit to philIip/react-native that referenced this pull request Aug 9, 2023
Summary:
Pull Request resolved: facebook#38870

Changelog: [iOS][Breaking]

i'm looking to limit callsites to the bridge in new architecture. in GH search i didn't see anyone using this method.

Differential Revision: D48175886

fbshipit-source-id: db67d2d68d01e0e226c959c552170e7d489bba2b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48175886

Summary:
Pull Request resolved: facebook#38870

## Changelog:

[iOS][Breaking] - hasBridge is removed from RCTRootView and RCTSurfaceHostingProxyRootView

i'm looking to limit callsites to the bridge in new architecture. in GH search i didn't see anyone using this method.

Reviewed By: cipolleschi

Differential Revision: D48175886

fbshipit-source-id: f10481d342bb23792af9af390b5f8162b5ba2db5
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48175886

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 57b86f7.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants