Fix lint warns in ReactHostInterface #38762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48018980 |
Summary: Pull Request resolved: facebook#38167 Changelog: [Internal] 1. Moving out `getSurfaceID()`, `getModuleName()` and `clear()` functions out of `ReactSurface` to interface `ReactSurface` as part of stable APIs. 2. Refactoring usages of `ReactSurface` to rely on interface `ReactSurface`. 3. Refactoring `ReactHost` to use `TaskInterface` as done similarly for `ReactSurface` Differential Revision: D47109982 fbshipit-source-id: 9031ffd22873fdee72331d3b0087a024cfbeee1a
Summary: Pull Request resolved: facebook#38762 Fix lint warns in ReactHostInterface Reviewed By: cortinico Differential Revision: D48018980 fbshipit-source-id: 5ed722ee25884fe2eb6a26f00f8b1dfea64decfe
|
This pull request was exported from Phabricator. Differential Revision: D48018980 |
arushikesarwani94
force-pushed
the
export-D48018980
branch
from
5f1dc33
to
da22cff
Compare
|
This pull request has been merged in a34ce64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix lint warns in ReactHostInterface
Differential Revision: D48018980