Fixup contentLength invalidation logic #38733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47978638 |
Base commit: a34ce64 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Aug 3, 2023
Summary: Pull Request resolved: facebook#38733 I was working under the assumption that Fabric fired layout events bottom up, but it actually fires them top-down, in constrast to Paper. Previous invalidation logic wasn't quite correct when fired bottom-up. This corrects the logic by: 1. Deriving direction based on initial event ordering 2. Use last cached contentLength if we are on Fabric (top-down) 3. Use future contentLength if we are on Paper (bottom-up) Changelog: [General][Fixed] - Fixup contentLength invalidation logic Reviewed By: rozele Differential Revision: D47978638 fbshipit-source-id: 3e17ccec3e23e72e0c04207086640d50c96755ed
NickGerleman
force-pushed
the
export-D47978638
branch
from
d48a653
to
c2a1e51
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47978638 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D47978638 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Aug 4, 2023
Summary: Pull Request resolved: facebook#38733 I was working under the assumption that Fabric fired layout events bottom up, but it actually fires them top-down, in constrast to Paper. Previous invalidation logic wasn't quite correct when fired bottom-up. This corrects the logic by: 1. Deriving direction based on initial event ordering 2. Use last cached contentLength if we are on Fabric (top-down) 3. Use future contentLength if we are on Paper (bottom-up) Changelog: [General][Fixed] - Fixup contentLength invalidation logic Reviewed By: rozele Differential Revision: D47978638 fbshipit-source-id: e43e7f3479659ff7f5a4ea620464dad627fc1f03
NickGerleman
force-pushed
the
export-D47978638
branch
from
c2a1e51
to
9b69205
Compare
Summary: Returned measurements from the measurements cache in RTL calculate offset as distance from the left edge of the cell to the right edge of the content, when it should instead be the distance from the right edge of the cell (the logical beginning). Changelog: [General][Fixed] - Return right edge in RTL cell metrics Differential Revision: D47978631 fbshipit-source-id: ac5101219b847c4c6ed7f83e2c9f573a09e7068f
Summary: This fixes up behavior on Android so that `scrollToIndex` aligns the right edge of the cell of the given index to the right edge of the scrollview viewport. We do not incorporate RTL on iOS which inverts x/y coordinates from scroller (but not layout). Changelog: [General][Fixed] - Right align scrollToIndex in RTL Differential Revision: D47978637 fbshipit-source-id: 0ec0235cb59917ce0d941c78210e9849d2311ae4
Summary: Pull Request resolved: facebook#38733 I was working under the assumption that Fabric fired layout events bottom up, but it actually fires them top-down, in constrast to Paper. Previous invalidation logic wasn't quite correct when fired bottom-up. This corrects the logic by: 1. Deriving direction based on initial event ordering 2. Use last cached contentLength if we are on Fabric (top-down) 3. Use future contentLength if we are on Paper (bottom-up) Changelog: [General][Fixed] - Fixup contentLength invalidation logic Reviewed By: rozele Differential Revision: D47978638 fbshipit-source-id: 8160b675dbb4946a394d7e5df7f3c4e04499c651
NickGerleman
force-pushed
the
export-D47978638
branch
from
9b69205
to
f67dc83
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47978638 |
|
This pull request has been merged in ace0a80. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I was working under the assumption that Fabric fired layout events bottom up, but it actually fires them top-down, in constrast to Paper.
Previous invalidation logic wasn't quite correct when fired bottom-up. This corrects the logic by:
Changelog:
[General][Fixed] - Fixup contentLength invalidation logic
Differential Revision: D47978638