Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow RCTAppDelegate pod to be imported as a module #38717

Closed
wants to merge 1 commit into from
Closed

Allow RCTAppDelegate pod to be imported as a module #38717

wants to merge 1 commit into from

Conversation

tsapeta
Copy link
Contributor

@tsapeta tsapeta commented Aug 1, 2023

Summary:

If another pod wants to depend on React-RCTAppDelegate and is written in Swift, the user needs to enable modular headers for this pod in the Podfile. This is not very convenient as this cannot be changed as part of the podspec, thus requires additional steps from the user. In Expo, our autolinking just fixes that automatically for all pods that require it (not only for RN's pods).

Changelog:

[IOS] [CHANGED] - Set DEFINES_MODULE xcconfig in React-RCTAppDelegate to generate a module map for this pod

Test Plan:

  • rn-tester builds
  • pod install with a dependency containing Swift code and depending on React-RCTAppDelegate no longer requires the user to use modular headers for this pod

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 1, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,890,106 +0
android hermes armeabi-v7a 7,938,112 -3
android hermes x86 9,287,765 +0
android hermes x86_64 9,189,420 +1
android jsc arm64-v8a 9,478,084 +2
android jsc armeabi-v7a 8,419,084 +2
android jsc x86 9,461,888 +2
android jsc x86_64 9,776,259 +2

Base commit: 5eaf28b
Branch: main

@cortinico cortinico added p: Expo Partner: Expo Partner p: Software Mansion Partner: Software Mansion labels Aug 1, 2023
@tsapeta tsapeta marked this pull request as ready for review August 1, 2023 13:06
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 1, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Contributor

We need to check whether this works on Xcode 14.1 😔
For React Native 0.72.2 we had issues with a similar PRs and we had to revert it.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

This pull request was successfully merged by @tsapeta in 7c79e31.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Expo Partner: Expo p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants