delete RCT_EXPORT_PRE_REGISTERED_MODULE #38707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47919116 |
Base commit: 5eaf28b |
Summary: Pull Request resolved: facebook#38707 Changelog: [iOS][Breaking] seemed like a confusing api, so getting rid of it also did not see any libraries using this in GH: https://github.com/search?q=RCT_EXPORT_PRE_REGISTERED_MODULE&type=code, so can just delete this safely Reviewed By: fkgozali Differential Revision: D47919116 fbshipit-source-id: 04b6d7213211576ff986a849ab08b5bd09605d9b
philIip
force-pushed
the
export-D47919116
branch
from
81e5685
to
02505d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47919116 |
|
This pull request was successfully merged by @philIip in 8cd5b2a. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [iOS][Breaking]
seemed like a confusing api, so getting rid of it
also did not see any libraries using this in GH: https://github.com/search?q=RCT_EXPORT_PRE_REGISTERED_MODULE&type=code, so can just delete this safely
Differential Revision: D47919116