Fix FpsDebugFrameCallback so that we properly cancel frame loop to avoid race #38671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47849848 |
ryancat
pushed a commit
to ryancat/react-native
that referenced
this pull request
Jul 28, 2023
…oid race (facebook#38671) Summary: Pull Request resolved: facebook#38671 Fix a race condition when we unmount and mount a view using FpsView too frequently. In this case, the frame loop callback didn't get a chance to unset the `mShouldStop` flag, causing the old frame loop continues to run unexpectedly. The fix here guarantees `stop` would queue logic that removes the frame loop callback, and a later `start` would queue logic that attaches a new frame loop callback. Since both of them happens on UI thread, they are in sync. Changelog: [Android][Fixed] - Fix a race with FpsView on using FpsDebugFrameCallback. Differential Revision: D47849848 fbshipit-source-id: cd87d418ad4115aac7d7905e6cb8dda39939bcc0
ryancat
force-pushed
the
export-D47849848
branch
from
e2d385e
to
e5e01ee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47849848 |
Base commit: eb5e7b2 |
|
This pull request was exported from Phabricator. Differential Revision: D47849848 |
ryancat
force-pushed
the
export-D47849848
branch
from
e5e01ee
to
fed3f70
Compare
ryancat
pushed a commit
to ryancat/react-native
that referenced
this pull request
Aug 3, 2023
…oid race (facebook#38671) Summary: Pull Request resolved: facebook#38671 Fix a race condition when we unmount and mount a view using FpsView too frequently. In this case, the frame loop callback didn't get a chance to unset the `mShouldStop` flag, causing the old frame loop continues to run unexpectedly. The fix here guarantees `stop` would queue logic that removes the frame loop callback, and a later `start` would queue logic that attaches a new frame loop callback. Since both of them happens on UI thread, they are in sync. Changelog: [Android][Fixed] - Fix a race with FpsView on using FpsDebugFrameCallback. Reviewed By: hoxyq Differential Revision: D47849848 fbshipit-source-id: 0509ffef38a21000994fbdf6325acc72bddb592f
ryancat
pushed a commit
to ryancat/react-native
that referenced
this pull request
Aug 3, 2023
…oid race (facebook#38671) Summary: Pull Request resolved: facebook#38671 Fix a race condition when we unmount and mount a view using FpsView too frequently. In this case, the frame loop callback didn't get a chance to unset the `mShouldStop` flag, causing the old frame loop continues to run unexpectedly. The fix here guarantees `stop` would queue logic that removes the frame loop callback, and a later `start` would queue logic that attaches a new frame loop callback. Since both of them happens on UI thread, they are in sync. Changelog: [Android][Fixed] - Fix a race with FpsView on using FpsDebugFrameCallback. Reviewed By: hoxyq Differential Revision: D47849848 fbshipit-source-id: 6dfa403e493df6a50bfb07dbb1469843aaf05f6e
ryancat
force-pushed
the
export-D47849848
branch
from
fed3f70
to
3b193c9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47849848 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D47849848 |
ryancat
force-pushed
the
export-D47849848
branch
from
3b193c9
to
d50b7ac
Compare
ryancat
pushed a commit
to ryancat/react-native
that referenced
this pull request
Aug 31, 2023
…oid race (facebook#38671) Summary: Pull Request resolved: facebook#38671 Fix a race condition when we unmount and mount a view using FpsView too frequently. In this case, the frame loop callback didn't get a chance to unset the `mShouldStop` flag, causing the old frame loop continues to run unexpectedly. The fix here guarantees `stop` would queue logic that removes the frame loop callback, and a later `start` would queue logic that attaches a new frame loop callback. Since both of them happens on UI thread, they are in sync. Changelog: [Android][Fixed] - Fix a race with FpsView on using FpsDebugFrameCallback. Reviewed By: hoxyq Differential Revision: D47849848 fbshipit-source-id: 2ce2e87470f690f51e852493c27cd6fe1d6bf874
|
This pull request was exported from Phabricator. Differential Revision: D47849848 |
ryancat
pushed a commit
to ryancat/react-native
that referenced
this pull request
Aug 31, 2023
…oid race (facebook#38671) Summary: Pull Request resolved: facebook#38671 Fix a race condition when we unmount and mount a view using FpsView too frequently. In this case, the frame loop callback didn't get a chance to unset the `mShouldStop` flag, causing the old frame loop continues to run unexpectedly. The fix here guarantees `stop` would queue logic that removes the frame loop callback, and a later `start` would queue logic that attaches a new frame loop callback. Since both of them happens on UI thread, they are in sync. Changelog: [Android][Fixed] - Fix a race with FpsView on using FpsDebugFrameCallback. Reviewed By: hoxyq Differential Revision: D47849848 fbshipit-source-id: 5523c7a4499d48abbe3f80e2cfc1ebed00b07f93
ryancat
force-pushed
the
export-D47849848
branch
from
d50b7ac
to
1d9180d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47849848 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D47849848 |
ryancat
pushed a commit
to ryancat/react-native
that referenced
this pull request
Sep 8, 2023
…oid race (facebook#38671) Summary: Fix a race condition when we unmount and mount a view using FpsView too frequently. In this case, the frame loop callback didn't get a chance to unset the `mShouldStop` flag, causing the old frame loop continues to run unexpectedly. The fix here guarantees `stop` would queue logic that removes the frame loop callback, and a later `start` would queue logic that attaches a new frame loop callback. Since both of them happens on UI thread, they are in sync. Changelog: [Android][Fixed] - Fix a race with FpsView on using FpsDebugFrameCallback. Reviewed By: hoxyq Differential Revision: D47849848
ryancat
force-pushed
the
export-D47849848
branch
from
1d9180d
to
0f1b23f
Compare
…oid race (facebook#38671) Summary: Fix a race condition when we unmount and mount a view using FpsView too frequently. In this case, the frame loop callback didn't get a chance to unset the `mShouldStop` flag, causing the old frame loop continues to run unexpectedly. The fix here guarantees `stop` would queue logic that removes the frame loop callback, and a later `start` would queue logic that attaches a new frame loop callback. Since both of them happens on UI thread, they are in sync. Changelog: [Android][Fixed] - Fix a race with FpsView on using FpsDebugFrameCallback. Reviewed By: hoxyq Differential Revision: D47849848
|
This pull request was exported from Phabricator. Differential Revision: D47849848 |
ryancat
force-pushed
the
export-D47849848
branch
from
0f1b23f
to
d38b35a
Compare
|
This pull request was successfully merged by Xin Chen in a63b443. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix a race condition when we unmount and mount a view using FpsView too frequently. In this case, the frame loop callback didn't get a chance to unset the
mShouldStopflag, causing the old frame loop continues to run unexpectedly.The fix here guarantees
stopwould queue logic that removes the frame loop callback, and a laterstartwould queue logic that attaches a new frame loop callback. Since both of them happens on UI thread, they are in sync.Changelog:
[Android][Fixed] - Fix a race with FpsView on using FpsDebugFrameCallback.
Differential Revision: D47849848