-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Switch.d.ts #38636
Update Switch.d.ts #38636
Conversation
updated type for activeThumbColor prop for Switch component
Hi @VickyA371! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Base commit: ad91518 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@lunaleaps merged this pull request in f493adc. |
/** | ||
* Color of the active foreground switch grip. | ||
*/ | ||
activeThumbColor?: ColorValue | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @VickyA371
Could you point me to the place where this prop is implemented? This is just the typescript type for it.
I believe this prop is not existing and this PR should be reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cortinico
I agree that this should be reverted. I did a thorough investigation in the android native code and found out that there is no such prop as activeThumbColor.
The reason I made this change was because I was working on a monorepo project and the prop activeThumbColor was working fine for react-native-web. However, when I added the import for react-native, I encountered some typescript errors that indicated that this prop was not supported.
Hence, I only modified the ts file to fix the errors.
This pull request has been reverted by a2e30dc. |
updated type for activeThumbColor prop for Switch component
Summary:
To help community users with all possible properties
Changelog:
[GENERAL] [ADDED] - Added activeThumbColor prop in type of Switch componentTest Plan: