Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Switch.d.ts #38636

Closed
wants to merge 1 commit into from
Closed

Update Switch.d.ts #38636

wants to merge 1 commit into from

Conversation

VickyA371
Copy link
Contributor

@VickyA371 VickyA371 commented Jul 26, 2023

updated type for activeThumbColor prop for Switch component

Summary:

To help community users with all possible properties

Changelog:

[GENERAL] [ADDED] - Added activeThumbColor prop in type of Switch component

Test Plan:

updated type for activeThumbColor prop for Switch component
@facebook-github-bot
Copy link
Contributor

Hi @VickyA371!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,889,617 -1
android hermes armeabi-v7a 7,940,145 -1
android hermes x86 9,287,502 -1
android hermes x86_64 9,191,332 -1
android jsc arm64-v8a 9,479,627 +0
android jsc armeabi-v7a 8,422,707 +1
android jsc x86 9,463,200 -3
android jsc x86_64 9,780,104 +2

Base commit: ad91518
Branch: main

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jul 26, 2023
@facebook-github-bot
Copy link
Contributor

@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@lunaleaps merged this pull request in f493adc.

/**
* Color of the active foreground switch grip.
*/
activeThumbColor?: ColorValue | undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VickyA371
Could you point me to the place where this prop is implemented? This is just the typescript type for it.

I believe this prop is not existing and this PR should be reverted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cortinico

I agree that this should be reverted. I did a thorough investigation in the android native code and found out that there is no such prop as activeThumbColor.

The reason I made this change was because I was working on a monorepo project and the prop activeThumbColor was working fine for react-native-web. However, when I added the import for react-native, I encountered some typescript errors that indicated that this prop was not supported.

Hence, I only modified the ts file to fix the errors.

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by a2e30dc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Reverted Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants