-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Hermes build for iOS on different executors to speed up CI and Releases #38619
Conversation
08c6bae
to
2b6ab59
Compare
Base commit: 1f24750 |
dbd4c0b
to
9b14a49
Compare
ad75204
to
3135b69
Compare
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
85a6b2a
to
d7c80bb
Compare
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
d7c80bb
to
b57fb18
Compare
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
b57fb18
to
94843e8
Compare
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
94843e8
to
ea2da1a
Compare
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
/rebase |
ea2da1a
to
e24905c
Compare
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was successfully merged by @cipolleschi in 79122ab. When will my fix make it into a release? | Upcoming Releases |
Summary:
This PR splits the build of Hermes for iOS in multiple jobs.
Before, we were building all the slices of Hermes serially. So, we were:
This job was taking up to 45-50 minutes.
The the four slices (iPhone, iPhonesimulator, Macos, Catalyst) can be parallelized to harvest a speedup in execution.
The following tables contains the executions before and after this change.
build_hermes_macos-Debug
= 51' 35"build_hermesc_apple
(2' 56") +build_apple_slices_hermes-Debug-macosx
(9'23") +build_hermes_macos-Debug
(5'14") = 17'33"build_hermes_macos-Debug
(4'35")build_hermesc_apple
(7") +build_apple_slices_hermes-Debug-macosx
(7") +build_hermes_macos-Debug
(32") = 46"Changelog:
[Internal] - Split hermes build to speedup CI and Release
Test Plan: