Remove need for each platform to implement ProgressBarAndroid as UnimplementedView #38608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47747116 |
Base commit: e64756a |
|
CC: @Saadnajmi / @chiaramooney |
…plementedView (facebook#38608) Summary: Pull Request resolved: facebook#38608 This file is forked in out of tree platforms as: - macOS > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.macos.js - Windows > https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.windows.js The change here removes the need of forking this file Changelog: [General] [Fixed] - [ProgressBarAndroid] Remove need for each platform to implement ProgressBarAndroid as UnimplementedView Reviewed By: rozele Differential Revision: D47747116 fbshipit-source-id: af35caafcaead6f9187505b7f6b3ae3afffaeb8b
christophpurrer
force-pushed
the
export-D47747116
branch
from
06ab946
to
c5881d0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47747116 |
|
This pull request has been merged in c02fcca. |
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
…plementedView (facebook#38608) Summary: Pull Request resolved: facebook#38608 This file is forked in out of tree platforms as: - macOS > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.macos.js - Windows > https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.windows.js The change here removes the need of forking this file Changelog: [General] [Fixed] - [ProgressBarAndroid] Remove need for each platform to implement ProgressBarAndroid as UnimplementedView Reviewed By: rozele Differential Revision: D47747116 fbshipit-source-id: 8c6d40baf8efc69fc8bf359ab400b6d2eec03839
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
…plementedView (facebook#38608) Summary: Pull Request resolved: facebook#38608 This file is forked in out of tree platforms as: - macOS > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.macos.js - Windows > https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.windows.js The change here removes the need of forking this file Changelog: [General] [Fixed] - [ProgressBarAndroid] Remove need for each platform to implement ProgressBarAndroid as UnimplementedView Reviewed By: rozele Differential Revision: D47747116 fbshipit-source-id: 8c6d40baf8efc69fc8bf359ab400b6d2eec03839
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
…plementedView (facebook#38608) Summary: Pull Request resolved: facebook#38608 This file is forked in out of tree platforms as: - macOS > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.macos.js - Windows > https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.windows.js The change here removes the need of forking this file Changelog: [General] [Fixed] - [ProgressBarAndroid] Remove need for each platform to implement ProgressBarAndroid as UnimplementedView Reviewed By: rozele Differential Revision: D47747116 fbshipit-source-id: 8c6d40baf8efc69fc8bf359ab400b6d2eec03839
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This file is forked in out of tree platforms as:
The change here removes the need of forking this file
Changelog:
[General] [Fixed] - [ProgressBarAndroid] Remove need for each platform to implement ProgressBarAndroid as UnimplementedView
Differential Revision: D47747116