Remove need for platform overrides to Settings #38607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47747018 |
Base commit: e64756a |
|
CC: @Saadnajmi / @chiaramooney |
Summary: Pull Request resolved: facebook#38607 Today, any host platform implementation of React Native must add Settings.platform.js. - https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Settings/Settings.windows.js Now they don't have to do it anymore. For this case, macOS actually wants to share the iOS specific logic > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Settings/Settings.macos.js Changelog: [General] [Fixed] - [Settings] Remove need for platform overrides to Settings Reviewed By: rozele Differential Revision: D47747018 fbshipit-source-id: ea824c45c952dd2118d7c4cbfc1b720b5b88192e
|
This pull request was exported from Phabricator. Differential Revision: D47747018 |
christophpurrer
force-pushed
the
export-D47747018
branch
from
243e3aa
to
60b6659
Compare
|
This pull request has been merged in 3c15b68. |
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38607 Today, any host platform implementation of React Native must add Settings.platform.js. - https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Settings/Settings.windows.js Now they don't have to do it anymore. For this case, macOS actually wants to share the iOS specific logic > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Settings/Settings.macos.js Changelog: [General] [Fixed] - [Settings] Remove need for platform overrides to Settings Reviewed By: rozele Differential Revision: D47747018 fbshipit-source-id: 8e4e8d318b3285a9a64e0b4f052f721f6242f871
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38607 Today, any host platform implementation of React Native must add Settings.platform.js. - https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Settings/Settings.windows.js Now they don't have to do it anymore. For this case, macOS actually wants to share the iOS specific logic > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Settings/Settings.macos.js Changelog: [General] [Fixed] - [Settings] Remove need for platform overrides to Settings Reviewed By: rozele Differential Revision: D47747018 fbshipit-source-id: 8e4e8d318b3285a9a64e0b4f052f721f6242f871
billnbell
pushed a commit
to billnbell/react-native
that referenced
this pull request
Jul 29, 2023
Summary: Pull Request resolved: facebook#38607 Today, any host platform implementation of React Native must add Settings.platform.js. - https://github.com/microsoft/react-native-windows/blob/0.71-stable/vnext/src/Libraries/Settings/Settings.windows.js Now they don't have to do it anymore. For this case, macOS actually wants to share the iOS specific logic > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Settings/Settings.macos.js Changelog: [General] [Fixed] - [Settings] Remove need for platform overrides to Settings Reviewed By: rozele Differential Revision: D47747018 fbshipit-source-id: 8e4e8d318b3285a9a64e0b4f052f721f6242f871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Today, any host platform implementation of React Native must add Settings.platform.js.
Now they don't have to do it anymore.
For this case, macOS actually wants to share the iOS specific logic > https://github.com/microsoft/react-native-macos/blob/main/Libraries/Settings/Settings.macos.js
Changelog:
[General] [Fixed] - [Settings] Remove need for platform overrides to Settings
Differential Revision: D47747018