-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ios fabric transform origin #38559
Closed
intergalacticspacehighway
wants to merge
21
commits into
facebook:main
from
intergalacticspacehighway:feat/ios-fabric-transformorigin
Closed
Changes from 3 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4b13fb1
feat: transform origin ios fabric
intergalacticspacehighway 26b8430
move transform in invalidateLayer
intergalacticspacehighway e65fbf3
fix: lint errors
intergalacticspacehighway fbaf6c0
revert needs invalidate layer
intergalacticspacehighway 35badaf
transform origin struct
intergalacticspacehighway 302a9aa
nit: pr suggestions
intergalacticspacehighway be6b4d5
revert non fabric changes
intergalacticspacehighway ffa6afc
fix: tests
intergalacticspacehighway ab174da
nit: header fix
intergalacticspacehighway a9632d6
merge main
intergalacticspacehighway eefec92
merge main
intergalacticspacehighway 40ed8db
fix: PR feedback
intergalacticspacehighway 8902301
fix: PR feedback
intergalacticspacehighway 0e91714
PR feedback
intergalacticspacehighway a74fdf8
remove redundant type
intergalacticspacehighway 854710a
fix min error
intergalacticspacehighway 9a3c230
fix min error
intergalacticspacehighway 55ad2c9
add value unit struct
intergalacticspacehighway 696621e
Apply suggestions from code review
intergalacticspacehighway 0f27a0c
Merge branch 'feat/add-value-unit-struct' into feat/ios-fabric-transf…
intergalacticspacehighway a30ed3d
use ValueUnit struct
intergalacticspacehighway File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
24 changes: 24 additions & 0 deletions
24
packages/react-native/ReactCommon/react/renderer/graphics/ValueUnit.h
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#pragma once | ||
|
||
namespace facebook::react { | ||
|
||
enum class UnitType { | ||
Undefined, | ||
Point, | ||
Percent, | ||
}; | ||
|
||
struct ValueUnit { | ||
float value{0.0f}; | ||
UnitType unit{UnitType::Undefined}; | ||
|
||
ValueUnit(float v, UnitType u) : value(v), unit(u) {} | ||
|
||
bool operator==(const ValueUnit& other) const { | ||
return value == other.value && unit == other.unit; | ||
} | ||
bool operator!=(const ValueUnit& other) const { | ||
return !(*this == other); | ||
} | ||
}; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need undefined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To represent initial/undefined value? Also useful to check the value is set. Check isSet in TransformOrigin struct.