Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TextInput vertical alignment issue when using lineHeight prop on iOS without changing Text baseline (Paper - old arch) #38359

Closed
wants to merge 11 commits into from
Closed

Fix TextInput vertical alignment issue when using lineHeight prop on iOS without changing Text baseline (Paper - old arch) #38359

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
07fdbf8
set baseline with RCTBaseTextInputShadowView
fabOnReact Jul 15, 2023
a900804
removing frame.size.height logic
fabOnReact Jul 15, 2023
352ab69
Merge branch 'main' into fix-copy-paste-with-refactor
fabOnReact Jul 17, 2023
28c8031
remove comment
fabOnReact Jul 18, 2023
bfa4bab
Merge branch 'main' into fix-copy-paste-with-refactor
fabOnReact Jul 18, 2023
fdb1e37
Merge branch 'main' into fix-copy-paste-with-refactor
fabOnReact Nov 7, 2023
13e7fc3
Merge branch 'main' into fix-copy-paste-with-refactor
fabOnReact Nov 7, 2023
ccf45f9
Merge branch 'main' into fix-copy-paste-with-refactor
fabOnReact Nov 8, 2023
4238e31
Merge branch 'main' into fix-copy-paste-with-refactor
fabOnReact Dec 16, 2023
90b24b6
Merge branch 'main' into fix-copy-paste-with-refactor
fabOnReact Dec 17, 2023
25eebf1
Merge branch 'main' into fix-copy-paste-with-refactor
fabOnReact Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removing frame.size.height logic
  • Loading branch information
@fabOnReact
fabOnReact committed Jul 15, 2023
commit a900804b0083c4fea0420b9e210c25891afd09b5
3 changes: 1 addition & 2 deletions packages/react-native/Libraries/Text/TextInput/RCTBaseTextInputShadowView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,7 @@ - (void)postprocessAttributedText:(NSMutableAttributedString *)attributedText
maximumLineHeight = MAX(paragraphStyle.maximumLineHeight, maximumLineHeight);
}];

CGFloat height = self.layoutMetrics.frame.size.height;
if (maximumLineHeight == 0 || maximumLineHeight > height) {
if (maximumLineHeight == 0) {
// `lineHeight` was not specified, nothing to do.
// or is higher then actual height
return;
Expand Down