Skip to content

Conversation

@branaust
Copy link
Contributor

@branaust branaust commented Jun 19, 2023

Summary:

Move the verifyProprsNotAlreadyDefined functions from Flow and from TypeScript to the parsers-commons.js file. Use the new function in place of the others.

Changelog:

[Internal] [Changed] - Moved verifyProprsNotAlreadyDefined to parsers-commons.js

Test Plan

@facebook-github-bot
Copy link
Contributor

Hi @branaust!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Pranav-yadav Pranav-yadav added the Tech: Codegen Related to react-native-codegen label Jun 19, 2023
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 19, 2023
@facebook-github-bot
Copy link
Contributor

@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @branaust, thanks for spending the time working on this. The code looks good! 😄 great job! 👏

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 20, 2023
@facebook-github-bot
Copy link
Contributor

@rshest merged this pull request in a108dcb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Tech: Codegen Related to react-native-codegen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants